BOOTCAMP: Alyan #251
Open
BOOTCAMP: Alyan #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EemanAleem
requested changes
Sep 28, 2025
| uint8_t rx[3]; | ||
|
|
||
| tx[0] = 0x01; | ||
| tx[1] = 0x90; |
There was a problem hiding this comment.
The transmit values are incorrect, recheck the ADC documentation for the crrect configuration!
|
|
||
| tx[0] = 0x01; | ||
| tx[1] = 0x90; | ||
| tx[2] = 0x00; |
There was a problem hiding this comment.
I would also suggest having lines 64 to 69 (variable declarations and initializations) be outside of this function because their values are unchanging throughout the while loop.
|
|
||
| HAL_GPIO_WritePin(CS_GPIO_PORT, CS_PIN, GPIO_PIN_RESET); | ||
|
|
||
| HAL_SPI_TransmitReceive(&hspi1, tx, rx, 3, HAL_MAX_DELAY); |
There was a problem hiding this comment.
- Use the error value returned from the TransmitReceive function to determine whether to continue with the rest of the code or not.
- Size must be in bytes and dependent on your tx size. sizeof(tx) ensures this.
- Assign the size to a variable -- no magic numbers! Improves readability.
| while (1) | ||
| { | ||
| uint16_t adc_val = ADC_Read(); | ||
| uint16_t PWM_val = 3200 + (adc_val * 3200) / 1023; |
There was a problem hiding this comment.
- Variable declarations should not be looped unnecessarily. Declare them outside of the while loop!
- Refer to previous comment on magic numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.