Skip to content

FIX: Attempt to fix UI test instabilities. [ISXB-1284] #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

ekcoh
Copy link
Collaborator

@ekcoh ekcoh commented May 23, 2025

Description

Attempt to fix automated UI test instabilities detected in CI.

Testing status & QA

Tests runs green locally on macOS after the proposed changes (consistently failed before the changes).

Overall Product Risks

Small risk, only affects test code and has positive impact on coverage.

  • Complexity: Small
  • Halo Effect: Small

Comments to reviewers

Nothing special to call out for reviewing this branch.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@codecov-github-com
Copy link

codecov-github-com bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2187      +/-   ##
===========================================
+ Coverage    65.45%   67.78%   +2.32%     
===========================================
  Files          367      367              
  Lines        53505    53505              
===========================================
+ Hits         35024    36268    +1244     
+ Misses       18481    17237    -1244     
Flag Coverage Δ
mac_2021.3_pkg 5.41% <ø> (ø)
mac_2021.3_project 70.42% <ø> (ø)
mac_2022.3_pkg 5.19% <ø> (ø)
mac_2022.3_project 65.29% <ø> (ø)
mac_6000.0_pkg 5.20% <ø> (ø)
mac_6000.0_project 67.70% <ø> (+2.32%) ⬆️
mac_6000.1_pkg 5.20% <ø> (ø)
mac_6000.1_project 67.70% <ø> (+2.33%) ⬆️
mac_6000.2_pkg 5.20% <ø> (ø)
mac_6000.2_project 67.70% <ø> (+2.33%) ⬆️
mac_trunk_pkg 5.20% <ø> (ø)
mac_trunk_project 67.70% <ø> (+2.33%) ⬆️
win_2021.3_pkg 5.42% <ø> (ø)
win_2021.3_project 70.49% <ø> (ø)
win_2022.3_pkg 5.20% <ø> (ø)
win_2022.3_project 65.37% <ø> (ø)
win_6000.0_pkg 5.20% <ø> (ø)
win_6000.0_project 67.78% <ø> (+2.33%) ⬆️
win_6000.1_pkg 5.20% <ø> (ø)
win_6000.1_project 67.78% <ø> (+2.33%) ⬆️
win_6000.2_pkg 5.20% <ø> (ø)
win_6000.2_project 67.78% <ø> (+2.33%) ⬆️
win_trunk_pkg 5.20% <ø> (ø)
win_trunk_project 67.78% <ø> (+2.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekcoh
Copy link
Collaborator Author

ekcoh commented Jun 4, 2025

Since the iOS CI noise was resolved with #2190 its likely easier to assess stability of this tentative fix now.

@ekcoh
Copy link
Collaborator Author

ekcoh commented Jun 4, 2025

Seen CI instabilities on this branch since the fix but none seem related to UI tests.

@ekcoh ekcoh marked this pull request as ready for review June 4, 2025 16:53
@ekcoh ekcoh requested review from jfreire-unity and Pauliusd01 June 4, 2025 16:53
@ekcoh
Copy link
Collaborator Author

ekcoh commented Jun 4, 2025

A few re-runs should be made on this before landing.

@ekcoh ekcoh merged commit 7da3aeb into develop Jun 5, 2025
129 checks passed
@ekcoh ekcoh deleted the isxb-1284-ui-test-instabilities branch June 5, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants