Fix cubemap & video clip reporting #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects-rr
force-pushed
the
report-cubemap-and-videoclip
branch
from
525d747 to
2dd34ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cubemaps & video clips do not currently have their size properly reported.
Add Cubemaps to the existing texture data, along with the 'ImageCount' field. Note, the files for this are called Texture2D*, but the databases are texture*, so they seem like the proper place to put all texture types. This code should potentially get updated for other texture types (Texture3D, Texture2DArray, etc...) however I don't have example content to test this with right now.
Add video clips to their own database & view