Disable pose broadcaster on mock hardware #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
========================================
+ Coverage 3.59% 3.78% +0.19%
========================================
Files 13 395 +382
Lines 947 43471 +42524
Branches 152 6398 +6246
========================================
+ Hits 34 1645 +1611
- Misses 843 41683 +40840
- Partials 70 143 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
As mock hardware doesn't send the same pose information as the real robot does, it does make sense to not start it in mock hardware. (cherry picked from commit 79252cf) # Conflicts: # ur_robot_driver/launch/ur_control.launch.py
1 task
urfeex
added a commit
that referenced
this pull request
Jan 14, 2025
As mock hardware doesn't send the same pose information as the real robot does, it does make sense to not start it in mock hardware. Co-authored-by: URJala <[email protected]> Co-authored-by: Felix Exner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1228