Skip to content

Disable pose broadcaster on mock hardware #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

URJala
Copy link
Collaborator

@URJala URJala commented Jan 13, 2025

Related to #1228

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.78%. Comparing base (1b121b7) to head (14efc5e).
Report is 381 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1229      +/-   ##
========================================
+ Coverage   3.59%   3.78%   +0.19%     
========================================
  Files         13     395     +382     
  Lines        947   43471   +42524     
  Branches     152    6398    +6246     
========================================
+ Hits          34    1645    +1611     
- Misses       843   41683   +40840     
- Partials      70     143      +73     
Flag Coverage Δ
unittests 3.78% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@URJala URJala requested a review from urfeex January 13, 2025 11:26
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@urfeex urfeex merged commit 79252cf into UniversalRobots:main Jan 13, 2025
14 checks passed
@urfeex
Copy link
Member

urfeex commented Jan 13, 2025

@Mergifyio backport humble

Copy link

mergify bot commented Jan 13, 2025

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 13, 2025
As mock hardware doesn't send the same pose information as the real robot does, it does make sense to not start it in mock hardware.

(cherry picked from commit 79252cf)

# Conflicts:
#	ur_robot_driver/launch/ur_control.launch.py
urfeex added a commit that referenced this pull request Jan 14, 2025
As mock hardware doesn't send the same pose information as the real robot does, it does make sense to not start it in mock hardware.

Co-authored-by: URJala <[email protected]>
Co-authored-by: Felix Exner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants