Trim the Flash README - #378
Closed
rejojer wants to merge 26 commits into
Closed
Conversation
# Conflicts: # run_pageindex.py
# Conflicts: # README.md # pageindex/flash/api.py # pageindex/tree_optimize.py # pageindex/utils.py # run_pageindex.py
Merged
Member
Author
|
Superseded by #379, opened from a fresh branch so the diff is not buried under the old release branch's history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trims the Flash package README and corrects what it claims.
The opening said "No LLM, no API key, no OCR, no network", directly above a
usage example that calls an LLM:
summary=Trueis the default, sopage_index_flash("paper.pdf")needs a key. Without one it does not raiseeither, it retries and returns empty summaries. The first line now says which
part needs a model and which does not, and the usage block shows all three
calls.
Also in this pass:
get back and where it goes.
has_abstract_or_references_sectionandsummary,both of which the function actually returns, and drops the
--optimizeCLIspelling from what is a Python dict.
pricing line are gone, along with
assets/cost_vs_pages.png. Token countsstay; they do not go stale when a price does.
74 lines to 71, and nothing in it is now contradicted by the code.