refactor: make MuonSpacePointDigitizer similar to DigitizationAlgorithm #4866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
junggjo9
reviewed
Dec 4, 2025
Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp
Outdated
Show resolved
Hide resolved
|
This was referenced Dec 10, 2025
junggjo9
reviewed
Dec 15, 2025
Comment on lines
+217
to
+219
| /// Transformation to the common coordinate system of all space points | ||
| const Transform3 parentTrf{toSpacePointFrame(gctx, moduleGeoId)}; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| /// Transformation to the common coordinate system of all space points | |
| const Transform3 parentTrf{toSpacePointFrame(gctx, moduleGeoId)}; |
Moved to lines 192ff
| const Surface* hitSurf = trackingGeometry().findSurface(moduleGeoId); | ||
| assert(hitSurf != nullptr); | ||
|
|
||
| const Transform3& surfLocToGlob{hitSurf->transform(gctx)}; |
Contributor
There was a problem hiding this comment.
Suggested change
| const Transform3& surfLocToGlob{hitSurf->transform(gctx)}; | |
| const Transform3& surfLocToGlob{hitSurf->transform(gctx)}; | |
| /// Transformation to the common coordinate system of all space points | |
| const Transform3 parentTrf{toSpacePointFrame(gctx, moduleGeoId)}; | |
| /// Retrieve the bounds | |
| const auto& bounds = hitSurf->bounds(); |
| const Vector3 locDir = | ||
| surfLocToGlob.inverse().linear() * simHit.direction(); | ||
|
|
||
| const auto& bounds = hitSurf->bounds(); |
Contributor
There was a problem hiding this comment.
Suggested change
| const auto& bounds = hitSurf->bounds(); |
Move upwards
| break; | ||
| } | ||
| } | ||
| /// Mark the |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Mark the | |
| /// Mark that a new hit has been recorded at this position & time | |
| /// Subsequent hits are rejected if they remain witihn the dead time |
| default: | ||
| convertSp = false; | ||
| } | ||
| /// Implement a dead time |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Implement a dead time | |
| /// Define the space point coordinates |
Comment on lines
+292
to
+293
| Vector3{parentTrf.linear() * Vector3::UnitY()}, | ||
| Vector3{parentTrf.linear() * Vector3::UnitX()}); |
Contributor
There was a problem hiding this comment.
Suggested change
| Vector3{parentTrf.linear() * Vector3::UnitY()}, | |
| Vector3{parentTrf.linear() * Vector3::UnitX()}); | |
| Vector3{parentTrf.linear().col(Acts::ePosY)}, | |
| Vector3{parentTrf.linear().col(Acts::ePosX)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align both algorithms when it comes to variable names and structure.