New: Move route definitions to routes.json (fixes #84)#85
Merged
Conversation
Co-authored-by: taylortom <1059083+taylortom@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor route definitions to use routes.json
Refactor: Move route definitions to routes.json
Feb 26, 2026
…efs #85) setValues() was missing the loadRouteConfig call so routes.json was never loaded. Also converts serveSchema from factory to standard handler, renames handler strings to match method names, adds API metadata from the removed apidefs.js, and adds adapt-authoring-server peer dependency.
#85) The override was using res.sendError() instead of next() for error propagation, and returning the raw schema object instead of schema.built. Both now match the base class convention in AbstractApiModule.
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route definitions were declared imperatively in
setValues()viauseDefaultRouteConfig(), manual deletions, androutes.push(). These are migrated to a declarativeroutes.jsonconsumed byloadRouteConfig(as already adopted byAbstractApiModuleandAbstractAuthModule).Update
setValues():useDefaultRouteConfig()call, POST/and PUT/:_iddeletions, androutes.push()for/install,/:_id/update,/:_id/usesapidefsimport andmiddlewarewaitForModulecall fromsetValues()New
routes.jsondeclaring the full route set withuseDefaultRoutes: false(POST/and PUT/:_idare excluded per existing behaviour):{ "root": "contentplugins", "useDefaultRoutes": false, "routes": [ { "route": "/", "handlers": { "get": "default" }, "permissions": { "get": ["read:{scope}"] } }, { "route": "/install", "validate": false, "handlers": { "post": "installHandler" }, "permissions": { "post": ["install:contentplugins"] } }, { "route": "/:_id/update", "handlers": { "post": "updateHandler" }, "permissions": { "post": ["update:contentplugins"] } }, { "route": "/:_id/uses", "handlers": { "get": "usesHandler" }, "permissions": { "get": ["read:contentplugins"] } } ] }Testing
contentpluginsroutes are registered at startupGET /api/contentplugins— list pluginsPOST /api/contentplugins/install— install a plugin via zip upload or version stringPOST /api/contentplugins/:_id/update— update a pluginGET /api/contentplugins/:_id/uses— retrieve plugin usage/and PUT/:_idare not registeredOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.