feat(picker): refactoring template markup, testing token passthroughs

[aramos-adobe]

Description

Refactored the Picker component template to encapsulate the popover, help text, label, and spectrum-Picker-button within a unified structure. The spectrum-Picker now acts as the root class, allowing for more targeted button styles and streamlined --mod and style passthroughs to child elements.

For example, --mod-popover-animation-distance—defined in the Popover—now registers correctly within the Picker, enabling size variant tokens to apply expected values when the corresponding size class is used.

New mod

--mod-picker-popover-animation-distance

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

1. Open the storybook for the picker component:
   - [ ] Correct --spectrum-picker-popover-animation-distance token changes according per size variant
   - [ ] Layout still works for top and side labels
   - [ ] Test grid environment still in tact

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

2. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• I have tested these changes in Windows High Contrast mode.
• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

🦋 Changeset detected

Latest commit: da7dad2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@spectrum-css/picker	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

File metrics

Summary

Total size: 1.41 MB^*

Package	Size	Minified	Gzipped
picker	28.63 KB	27.36 KB	3.50 KB

picker

Filename	Head	Minified	Gzipped	Compared to base
index.css	28.63 KB	27.36 KB	3.50 KB	🟢 ⬇ 0.02 KB
metadata.json	14.42 KB	-	-	🔴 ⬆ 0.16 KB

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[github-actions]

🚀 Deployed on https://pr-3792--spectrum-css.netlify.app

[marissahuysentruyt]

I think there's some style fixes that need to be addressed, specifically for the quiet variants. I left a thought about probably reimplementing the isQuiet arg getting passed to Picker() (not Template()). We'll also need to double check the side+quiet variant since the text alignment is pretty wonky:

This PR preview:

The table migration preview:

[marissahuysentruyt]

I'm not totally sure where to put this comment, but I think it's related to the removal of this isQuiet arg.

I noticed on the docs page that the Quiet Invalid story has borders. I'm not certain where that code lives however...

If I put the .spectrum-Picker--quiet on the button itself, the borders are removed as expected.

Preview:

Other recent PR preview (from the table migration):

[marissahuysentruyt]

@aramos-adobe Would you be open to adding a test case where we check side + quiet pickers? That's the controls I used to find the text alignment issue.