Skip to content

update language in banner #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

update language in banner #52

wants to merge 2 commits into from

Conversation

aeon1234
Copy link
Contributor

@aeon1234 aeon1234 commented Oct 2, 2018

created this PR after my comment got positive feedback in #2

I renamed Features heading from A lightweight CryptoNote digital currency to Features, because it will be basically same as in banner. if you have any better idea, please let me know.

paging
@sci-comp
@shigutso
@BigslimVdub
@thriftyMinnow
@camthegeek

preview
aeon1
aeon2

@aeon1234 aeon1234 closed this Oct 2, 2018
@aeon1234 aeon1234 reopened this Oct 2, 2018
@BigslimVdub
Copy link
Contributor

Looks good

@sci-comp
Copy link

sci-comp commented Oct 6, 2018 •
edited
Loading

I like it!

marmulak has offered to provide translations for a few different languages. Can we get this PR accepted and make another to add in marmulak's work?

@shigutso
Copy link
Contributor

shigutso commented Oct 6, 2018

a small, but nice change :)

@thriftyMinnow
Copy link

YES!! Please do this! Pretty-please?

@BigslimVdub
Copy link
Contributor

Are we going to change the official tagline to this as well: "Aeon, A lightweight digital currency" ?
https://www.reddit.com/r/Aeon/comments/9g7ij8/revisit_the_aeon_tagline/

@bitlamas
Copy link

bitlamas commented Oct 6, 2018

a lightweight digital currency sounds good to me, it's what aeon's try to achieve anyway. +1

@Cactii1
Copy link

Cactii1 commented Oct 8, 2018

A light, private digital currency.

@mikeV02
Copy link

mikeV02 commented Oct 10, 2018

I like this new tag. I am in favor of the change!

This was referenced Oct 12, 2018
Open
Open
stoffu
stoffu approved these changes Oct 14, 2018
View reviewed changes
Copy link
Contributor

@stoffu stoffu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems like a conflict needs to be resolved.

@BigslimVdub
Copy link
Contributor

@aeon1234 can you look into the conflicting file and get that fixed so we can merge this? Thanks!

@aeon1234
Copy link
Contributor Author

sorry. looks like the conflict is fixed but I don't know how to squash these commits. I think this looks ugly.

@stoffu
Copy link
Contributor

stoffu commented Oct 22, 2018

@aeon1234
I've looked into the commits and tried squashing them myself, to no avail. I'm no git expert, and the merge commit seems to make things messy. I think creating another PR is a practical option.

@aeon1234 aeon1234 closed this Oct 23, 2018
@aeon1234 aeon1234 reopened this Oct 23, 2018
@aeon1234 aeon1234 closed this Oct 23, 2018
@aeon1234
update language in banner
f65327b 
* fix responsive css in download

* make footer links underline on hover

* add aeon funding system to navbar

* add ChangeNOW to exchanges

* add zipped press kit

* add zipped press kit download link

* rename funding system link in navbar

* add GUI downloads

* fix typo GitHub in footer

* fix banner-content responsive

* Change download links to 0.12.6 release

* update language in banner

* update features header
@aeon1234 aeon1234 reopened this Oct 23, 2018
@aeon1234 aeon1234 mentioned this pull request Oct 23, 2018
Merged
@aeon1234 aeon1234 closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoffu stoffu stoffu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aeon1234 @BigslimVdub @sci-comp @shigutso @thriftyMinnow @bitlamas @Cactii1 @mikeV02 @stoffu