Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isLawfulEq proofs #280

Merged
merged 12 commits into from
Feb 20, 2024
Merged

isLawfulEq proofs #280

merged 12 commits into from
Feb 20, 2024

Conversation

odderwiser
Copy link
Contributor

  • proofs for Lawful Eq: List, Nat, Int, Integer, Word, Unit, Either, Tuple, Char
  • bug fix in tuple equality comparison
  • change the implementation of Char equality (impossible to prove on primitives)

jespercockx
jespercockx approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jespercockx jespercockx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thank you!

omelkonian
omelkonian approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor remarks.

@omelkonian omelkonian merged commit 79ae635 into agda:master Feb 20, 2024
@jespercockx jespercockx added this to the 1.3 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omelkonian omelkonian omelkonian approved these changes

@jespercockx jespercockx jespercockx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@odderwiser @jespercockx @omelkonian