Fix stale element hit-testing cache causing selection to feel stuck#286
Draft
Fix stale element hit-testing cache causing selection to feel stuck#286
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes hover/selection box not appearing in activation mode on pages that block
pointermoveevents in the bubbling phase.Why
Some sites attach
pointermovelisteners that callstopImmediatePropagation()(bubble). Ourpointermovelistener was registered without capture, sohandlePointerMovenever ran →detectedElementstayed null → selection box never appeared.How
pointermovelistener in capture phase (capture: true).pointermoveblocker and asserts the selection box still appears.Tests
pnpm --filter react-grab testpnpm testSummary by cubic
Fix hit-testing cache returning stale elements and restore hover selection when pages block
pointermove.getElementAtPositionnow reuses cache only when the pointer is close and within the throttle window, and we listen topointermovein capture phase to avoid bubbling blocks.Written for commit 9675cc2. Summary will update on new commits.