Skip to content

Fix stale element hit-testing cache causing selection to feel stuck #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aidenybai wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix stale element hit-testing cache causing selection to feel stuck #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0989bd
Fix element hit-test cache returning stale targets
cursoragent Apr 8, 2026
9675cc2
Fix hover selection when pointermove is blocked
cursoragent Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/react-grab/e2e/selection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,23 @@ test.describe("Element Selection", () => {
expect(clipboardContent.length).toBeGreaterThan(0);
});

test("should show selection even when page blocks pointermove bubbling", async ({ reactGrab }) => {
await reactGrab.activate();

await reactGrab.page.evaluate(() => {
window.addEventListener(
"pointermove",
(event) => {
event.stopImmediatePropagation();
},
{ capture: false },
);
});

await reactGrab.hoverElement("li");
await reactGrab.waitForSelectionBox();
});

test("should copy heading element to clipboard", async ({ reactGrab }) => {
await reactGrab.activate();
await reactGrab.hoverElement("[data-testid='todo-list'] h1");
Expand Down
2 changes: 1 addition & 1 deletion packages/react-grab/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
"devDependencies": {
"@babel/core": "^7.28.5",
"@babel/preset-typescript": "^7.28.5",
"solid-js": "^1.9.10",
"@playwright/test": "^1.40.0",
"@tailwindcss/cli": "^4.1.17",
"@types/babel__core": "^7.20.5",
Expand All @@ -111,6 +110,7 @@
"babel-preset-solid": "^1.9.10",
"concurrently": "^9.1.2",
"expect-sdk": "0.0.0-canary-20260405095424",
"solid-js": "^1.9.10",
"tailwindcss": "^4.1.0",
"tsx": "^4.21.0"
},
Expand Down
5 changes: 3 additions & 2 deletions packages/react-grab/src/core/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ export const init = (rawOptions?: Options): ReactGrabAPI => {
const isDragging = createMemo(
() =>
store.current.state === "active" &&
(store.current.phase === "dragging-select" || store.current.phase === "dragging-reposition"),
(store.current.phase === "dragging-select" ||
store.current.phase === "dragging-reposition"),
);
const isDragRepositioning = createMemo(
() => store.current.state === "active" && store.current.phase === "dragging-reposition",
Expand Down Expand Up @@ -2569,7 +2570,7 @@ export const init = (rawOptions?: Options): ReactGrabAPI => {
}
handlePointerMove(event.clientX, event.clientY);
},
{ passive: true },
{ passive: true, capture: true },
);

eventListenerManager.addWindowListener(
Expand Down
7 changes: 1 addition & 6 deletions packages/react-grab/src/core/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,7 @@ interface FrozenDragRect {
height: number;
}

type GrabPhase =
| "hovering"
| "frozen"
| "dragging-select"
| "dragging-reposition"
| "justDragged";
type GrabPhase = "hovering" | "frozen" | "dragging-select" | "dragging-reposition" | "justDragged";

type GrabState =
| { state: "idle" }
Expand Down
2 changes: 1 addition & 1 deletion packages/react-grab/src/utils/get-element-at-position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const getElementAtPosition = (clientX: number, clientY: number): Element
const isPositionClose = isWithinThreshold(clientX, clientY, cache.clientX, cache.clientY);
const isWithinThrottle = now - cache.timestamp < ELEMENT_POSITION_THROTTLE_MS;

if (isPositionClose || isWithinThrottle) {
if (isPositionClose && isWithinThrottle) {
return cache.element;
}
}
Expand Down
Loading