Skip to content

Delete the vestigial github-app-id input #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesgreen merged 1 commit into from
Aug 2, 2026
Merged

Delete the vestigial github-app-id input #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/simplycubed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ on:
default: ""
required: false
type: string
github-app-id:
description: Deprecated, kept so an existing caller keeps working. Pass
github-app-client-id instead.
default: ""
required: false
type: string
issue-number:
description: Issue number to run, when triggered from issues:labeled.
default: ""
Expand Down Expand Up @@ -80,7 +74,7 @@ jobs:
id: app-token
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ inputs['github-app-client-id'] || inputs['github-app-id'] }}
client-id: ${{ inputs['github-app-client-id'] }}
private-key: ${{ secrets['github-app-private-key'] }}
owner: ${{ steps.repo.outputs.owner }}
repositories: ${{ steps.repo.outputs.name }}
Expand Down Expand Up @@ -168,7 +162,7 @@ jobs:
id: app-token
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ inputs['github-app-client-id'] || inputs['github-app-id'] }}
client-id: ${{ inputs['github-app-client-id'] }}
private-key: ${{ secrets['github-app-private-key'] }}
owner: ${{ steps.repo.outputs.owner }}
repositories: ${{ steps.repo.outputs.name }}
Expand Down