Delete the vestigial github-app-id input - #117
Merged
Merged
Conversation
#93 moved the token action to the client ID. The old input survived as a fallback for callers that no longer exist, and the generated caller has never passed it. It also invites the wrong credential. The name says App ID, which is the numeric value on the App settings page, but create-github-app-token needs the Iv23 client ID. An adopter reading the input list had a documented reason to supply the wrong one. CHANGELOG entries are left alone. They record what shipped in past releases and are not instructions. Closes #116
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116.
#93 moved the token action to the client ID. The old
github-app-idinput survived as a fallback for callers that do not exist, and the generated caller has never passed it.It also invited the wrong credential: the name says App ID, which is the numeric value on the App settings page, while
actions/create-github-app-tokenneeds theIv23…client ID. An adopter reading the input list had a documented reason to supply the wrong one, and the resulting failure did not say so.Changed
github-app-idinput from.github/workflows/simplycubed.ymlinputs['github-app-client-id']directly instead of falling backLeft alone
CHANGELOG entries mentioning
github-app-idstay. They record what shipped in past releases and are not instructions to anyone.Why this is human-merged
It edits
.github/workflows/, and the App holds noworkflowspermission by design, so the agent cannot push it.make checkgreen locally.