Add a force_mtime() function to allow overriding all mtime fields #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamqqqplay
reviewed
Oct 13, 2023
There was a problem hiding this comment.
@grahamc Hi grahamc, it looks like the CI test is failing, maybe you could fix it first, thanks!
|
We certainly could. Does that mean you're interested in accepting this change as designed? |
|
Hi @grahamc 👋 This relates a lot to e.g. #346 and #343 a bit. In your use case, do you also want to canonicalize uid/gid? I'd guess so...which would argue that we should fix Also I think we should call out that it's really not terribly hard to do "manually" walk a directory recursively and add entries to it: We could put that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
Thanks for the excellent tar crate. While developing a project, we needed a way to override the mtime. This was the most direct route to get it done, even though I'm rather sure it isn't something you'd want to merge upstream.
So, here is some code we wrote. We're sending the PR for you to look at and consider as a use case. We'd be interested in hearing back from you if you're interested in a better implementation, and if so what you think that might look like.
Thank you!