fix(playwright): use vnd.allure.playwright-trace content type for trace attachments (fixes #1381) - #1380
Open
antonfilichkin wants to merge 1 commit into
Conversation
antonfilichkin
marked this pull request as draft
August 13, 2026 08:41
antonfilichkin
changed the title
1 task
antonfilichkin
force-pushed
the
fix/playwright-trace-content-type
branch
from
August 13, 2026 14:01
91a8d7d to
6c17e4e
Compare
antonfilichkin
marked this pull request as ready for review
August 13, 2026 14:03
antonfilichkin
force-pushed
the
fix/playwright-trace-content-type
branch
from
August 13, 2026 14:04
6180db2 to
f989368
Compare
antonfilichkin
marked this pull request as draft
August 13, 2026 14:06
…ce attachments AllurePlaywright.attachTrace() tagged Playwright trace archives with the generic application/zip content type, so the Allure report rendered them as a plain zip download instead of the embedded trace viewer. Add a shared AttachmentType.PLAYWRIGHT_TRACE constant (application/vnd.allure.playwright-trace, mapped to WellKnownFileExtensionsUtils' .zip extension) and switch attachTrace() to use it, keeping the .zip extension behavior unchanged.
antonfilichkin
force-pushed
the
fix/playwright-trace-content-type
branch
from
August 13, 2026 14:14
f989368 to
0e414c3
Compare
antonfilichkin
marked this pull request as ready for review
August 13, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #1381
Problem
AllurePlaywright.attachTrace()attached Playwright trace archives using the genericapplication/zipcontent type, so the Allure report rendered them as a plain zip download instead of using the built-in embedded trace viewer.Fix
Added a shared
AttachmentType.PLAYWRIGHT_TRACEconstant (application/vnd.allure.playwright-trace, already registered inWellKnownFileExtensionsUtilsmapped to the.zipextension) alongside the other predefined types (PNG,ZIP,WEBM, ...), and switchedattachTrace()to use it. The.zipfile extension behavior is unchanged.Testing
Extended the three existing trace-attachment tests to assert the attachment's
typeisAttachmentType.PLAYWRIGHT_TRACE.getMediaType(), in addition to the existing zip-payload checks.Checklist