Skip to content

fix(playwright): use vnd.allure.playwright-trace content type for trace attachments (fixes #1381) #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonfilichkin wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

fix(playwright): use vnd.allure.playwright-trace content type for trace attachments (fixes #1381) #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions allure-model/src/main/java/io/qameta/allure/model/AttachmentType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ public final class AttachmentType {
*/
public static final AttachmentType OCTET_STREAM = new AttachmentType("application/octet-stream", "");

/**
* Predefined attachment type for Playwright trace archives.
*/
public static final AttachmentType PLAYWRIGHT_TRACE = new AttachmentType("application/vnd.allure.playwright-trace", ZIP.getExtension());

private final String mediaType;
private final String extension;

Expand Down
2 changes: 1 addition & 1 deletion allure-playwright/src/main/java/io/qameta/allure/playwright/AllurePlaywright.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public static void attachPageErrors(final String name, final Page page) {
* @param traceZip the path to the trace zip file.
*/
public static void attachTrace(final String name, final Path traceZip) {
attachPath(defaultName(name, TRACE), AttachmentType.ZIP, traceZip);
attachPath(defaultName(name, TRACE), AttachmentType.PLAYWRIGHT_TRACE, traceZip);
}

/**
Expand Down
10 changes: 10 additions & 0 deletions allure-playwright/src/test/java/io/qameta/allure/playwright/AllurePlaywrightTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import io.qameta.allure.Param;
import io.qameta.allure.Step;
import io.qameta.allure.model.Attachment;
import io.qameta.allure.model.AttachmentType;
import io.qameta.allure.model.Status;
import io.qameta.allure.model.StatusDetails;
import io.qameta.allure.model.StepResult;
Expand Down Expand Up @@ -361,6 +362,9 @@ void shouldAttachTraceWhenSessionIsClosed() {

assertThat(results.getAttachments())
.hasSize(1);
assertThat(attachments(results))
.extracting(Attachment::getType)
.containsExactly(AttachmentType.PLAYWRIGHT_TRACE.getMediaType());
assertAttachmentStartsWith(results, ZIP_HEADER);
}

Expand All @@ -385,6 +389,9 @@ void shouldAttachTraceWhenContextIsClosed() {

assertThat(results.getAttachments())
.hasSize(1);
assertThat(attachments(results))
.extracting(Attachment::getType)
.containsExactly(AttachmentType.PLAYWRIGHT_TRACE.getMediaType());
assertAttachmentStartsWith(results, ZIP_HEADER);
}

Expand All @@ -408,6 +415,9 @@ void shouldAttachTraceWhenAllureLifecycleStopsTest() {

assertThat(results.getAttachments())
.hasSize(1);
assertThat(attachments(results))
.extracting(Attachment::getType)
.containsExactly(AttachmentType.PLAYWRIGHT_TRACE.getMediaType());
assertAttachmentStartsWith(results, ZIP_HEADER);
}

Expand Down
Loading