Optimize and create multiple SNP guests in the Ubuntu Host#24
Optimize and create multiple SNP guests in the Ubuntu Host#24LakshmiSaiHarika wants to merge 4 commits intoamd:mainfrom
Conversation
LakshmiSaiHarika
force-pushed
the
create-multiple-guests
branch
3 times, most recently
from
0476cc5 to
0a58ee3
Compare
LakshmiSaiHarika
changed the title
|
Hey @ryansavino and @DGonzalezVillal , I request for this PR review for the optimization of SNP guest creation process in the ubuntu host as per our previous meeting. Please let me know if any changes are required |
DGonzalezVillal
left a comment
DGonzalezVillal
left a comment
There was a problem hiding this comment.
A question related to current functionality and just a suggestion about your comments.
LakshmiSaiHarika
force-pushed
the
create-multiple-guests
branch
2 times, most recently
from
09b6f06 to
0801550
Compare
DGonzalezVillal
left a comment
DGonzalezVillal
left a comment
There was a problem hiding this comment.
The one comment. Besides that it lgtm
| User created SNP guest via guest-name option can be stopped with the `--guest-name` option as follows: | ||
| ``` | ||
| ./snp.sh stop-guests --guest-name <user-guest-name> | ||
| ``` |
There was a problem hiding this comment.
I don't see this as part of the code, are you meaning to add it?
There was a problem hiding this comment.
In the documentation, I was just highlightling a way to stop guest for a specific guest.
--guest-name option sets the IMAGE env. variable for that specific guest, which stops the running IMAGE env variable as per the stop_guests() function.
Let me know if we don't want to show this in documentation?
There was a problem hiding this comment.
My bad, I misunderstood how that worked, you can ignore that.
There was a problem hiding this comment.
No worries, @DGonzalezVillal , thanks for approving this PR.
Hi @ryansavino , please let me know if any changes are required in this PR.
LakshmiSaiHarika
changed the title
Signed-off-by: Harika Nittala <lnittala@amd.com>
… a separate SNP guest This supports launch of various SNP Guests at the same time using unique guest name and guest qemu port. A separate SNP guest can be launched with the --guest-name and --guest-port command option as follows: ./snp.sh launch-guest --guest-name <user-guest-name> --guest-port <user-guest-port> Signed-off-by: Harika Nittala <lnittala@amd.com>
Updated to show the correct details for the guest SSH access. Signed-off-by: Harika Nittala <lnittala@amd.com>
…tion process Updated the ubuntu guest download process to download it once and re-use the same image to quickly create multiple guests with the improved performance. Update of the guest image download structure in ubuntu also helps to easily add support for the same in the other OS linux distros. Signed-off-by: Harika Nittala <lnittala@amd.com>
LakshmiSaiHarika
force-pushed
the
create-multiple-guests
branch
from
0801550 to
7edf7e1
Compare
LakshmiSaiHarika
changed the title
3 participants
Users can launch multiple SNP enabled guests at the same time using --guest-name option and export of HOST_SSH_PORT env. variables
Modified snp.sh to create a separate guest user directory and point the launch working directory to point the current specific guest user directory.
Enhanced the guest creation process via the download of base guest image from the URL once and re-use the same base guest image to create multiple SNP enabled guests.