Added ZCU102 version for the AD9467 #2957
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to match main
JRabacca
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
13 tasks
nunojsa
reviewed
Oct 2, 2025
There was a problem hiding this comment.
Hi,
Thanks for your contribution. Some comments though:
- Please don't do merge commits;
- Use proper commit subjects (following the kernel style)
Having the above in mind, please:
- Rebase the branch onto main to remove merge commits
- Use git log --oneline on the relevant directories to see proper commit message examples (suggestion below):
arm64: dts: xilinx: add AD9467 support for ZCU102
arm64: defconfig: add AD9467 firmware files
| }; | ||
|
|
||
| &fmc_spi { | ||
| status = "okay"; |
There was a problem hiding this comment.
Wrong indentation. Please use tabs
| spi-max-frequency = <10000000>; | ||
| adi,spi-3wire-enable; | ||
|
|
||
| // clocks = <&clk_ad9517 3>; |
There was a problem hiding this comment.
Drop commented lines unless there's a good reason to keep them
This is to provide support for the ZCU102 AD9467 Signed-off-by: JRabacca <[email protected]>
Mainly copied from the Zedboard dts. Modified to be similar to other ZCU102 dts files. Signed-off-by: JRabacca <[email protected]>
The CI, that patches other branches, is only meaningful at the main repo. Mirroring of the patched branches can be done with the mirroring procedure. Signed-off-by: Jorge Marques <[email protected]>
Fix missing repo name. Signed-off-by: Jorge Marques <[email protected]>
Fix -Wcast-function-type-strict thrown by LLVM by explicity defining a compatible function to disable the clk. On top of that add proper error handling on devm_add_action_or_reset() call. Signed-off-by: Nuno Sá <[email protected]>
At a job without checkout, the folder won't exist, curl to root instead. Signed-off-by: Jorge Marques <[email protected]>
Signed-off-by: JRabacca <[email protected]>
|
Hi I rebased the commits, reworded the commit subjects, and changed the spaces to tabs. Unfortunately, I messed up somewhere and the commits that were previously authored and push by other people are appearing as a commit on mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Created a new dts and dtsi files for the AD9467 on the ZCU102. The files were based on the Zedboard versions. They were then modified to match the needs of ZCU102. This included additional i2c and system info nodes and changes to base addresses.
To be merged together with the HDL PR analogdevicesinc/hdl#1924
PR Type
PR Checklist