projects/ad9467_fmc: Add support on ZCU102 #1924
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JuanRafael Rabacca <[email protected]>
Signed-off-by: JuanRafael Rabacca <[email protected]>
LVDS uses DIFF_TERM_ADV and TERM_100 since ZCU102 HPC0 is only 1.8V SPI pins also changed to LVCMOS18 due to 1.8V limit of ZCU102 Signed-off-by: JuanRafael Rabacca <[email protected]>
JRabacca
requested review from
IuliaCMoldovan and
cristianmihaipopa
as code owners
|
|
|
I've been informed that the 2023_R2 branch isn't usually edited. |
|
Reopened. Closed the wrong pull request. Previous comment was for the linux repository |
IuliaCMoldovan
changed the title
IuliaCMoldovan
requested changes
Sep 24, 2025
Update to match main
Signed-off-by: JuanRafael Rabacca <[email protected]>
JRabacca
requested review from
LBFFilho,
StancaPop and
gastmaier
as code owners
Co-authored-by: Iulia Ivanov <[email protected]>
Co-authored-by: Iulia Ivanov <[email protected]>
Co-authored-by: Iulia Ivanov <[email protected]>
Co-authored-by: Iulia Ivanov <[email protected]>
Co-authored-by: Iulia Ivanov <[email protected]>
Co-authored-by: Iulia Ivanov <[email protected]>
Signed-off-by: JuanRafael Rabacca <[email protected]>
6 tasks
Signed-off-by: JuanRafael Rabacca <[email protected]>
|
|
||
| input [12:0] gpio_bd_i, | ||
| output [ 7:0] gpio_bd_o, | ||
|
|
There was a problem hiding this comment.
Are there spaces on line 42? The guideline checker complains about spaces being here, and if so, then they should be removed, to have an empty line.
The checker is also complaining about the license header as "not being updated" but this is a bug that I know of and we're in the process of updating the checker.
There was a problem hiding this comment.
There was. I've pushed a commit deleting the space at commit 0ca0740
Signed-off-by: JuanRafael Rabacca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adapted the HDL files from AD9467 Zedboard to AD9467 ZCU102.
Previously it had no prior support.
Unsure of any code style guidelines, but files were copied from existing examples and were modified as needed.
To be merged together with the Linux PR analogdevicesinc/linux#2957.
PR Type
PR Checklist