Skip to content

refactor: remove dependency on @angular/platform-browser-dynamic #29889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 19, 2025

This commit remove the dependency on @angular/platform-browser-dynamic from new projects.

This is now possible due to angular/angular#60453

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 19, 2025
@alan-agius4 alan-agius4 force-pushed the platform-browser-dynamic-remove branch 3 times, most recently from a0b6a90 to 464fa6e Compare March 19, 2025 19:38
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 19, 2025
@alan-agius4 alan-agius4 force-pushed the platform-browser-dynamic-remove branch from 464fa6e to bcbe7da Compare March 19, 2025 19:41
@alan-agius4 alan-agius4 force-pushed the platform-browser-dynamic-remove branch from bcbe7da to a4156ee Compare March 19, 2025 19:50
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects.

This is now possible due to angular/angular#60453
`platformBrowserTesting` currently does not include the right providers. See: angular/angular#60480
@alan-agius4 alan-agius4 force-pushed the platform-browser-dynamic-remove branch from a4156ee to e5e51a2 Compare March 20, 2025 07:52
@angular-robot angular-robot bot removed the area: build & ci Related the build and CI infrastructure of the project label Mar 20, 2025
@alan-agius4 alan-agius4 requested a review from clydin March 20, 2025 08:46
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 20, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review March 20, 2025 08:46
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 20, 2025
@alan-agius4 alan-agius4 merged commit d89c2cb into angular:main Mar 20, 2025
31 checks passed
@alan-agius4 alan-agius4 deleted the platform-browser-dynamic-remove branch March 20, 2025 13:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants