Skip to content

refactor: remove dependency on @angular/platform-browser-dynamic #29889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

refactor: remove dependency on @angular/platform-browser-dynamic #29889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15a91d2
refactor: remove dependency on `@angular/platform-browser-dynamic`
alan-agius4 Mar 19, 2025
e5e51a2
refactor: use `platformBrowser` instead of `platformBrowserTesting`
alan-agius4 Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/testing/builder/projects/hello-world-app/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
* found in the LICENSE file at https://angular.dev/license
*/

import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';

import { AppModule } from './app/app.module';

platformBrowserDynamic()
platformBrowser()
.bootstrapModule(AppModule)
.catch(err => console.log(err));
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
"@angular/material": "20.0.0-next.2",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#d25ced20c12ad010c2b5b560acb78065f8d6564e",
"@angular/platform-browser": "20.0.0-next.3",
"@angular/platform-browser-dynamic": "20.0.0-next.3",
"@angular/platform-server": "20.0.0-next.3",
"@angular/router": "20.0.0-next.3",
"@angular/service-worker": "20.0.0-next.3",
Expand Down
3 changes: 0 additions & 3 deletions packages/angular/build/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ ts_project(
"//:node_modules/@angular/compiler-cli",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//:node_modules/@angular/platform-browser-dynamic",
"//:node_modules/@angular/router",
"//:node_modules/rxjs",
"//:node_modules/tslib",
Expand Down Expand Up @@ -202,7 +201,6 @@ ts_project(
"//:node_modules/@angular/compiler-cli",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//:node_modules/@angular/platform-browser-dynamic",
"//:node_modules/@angular/router",
":node_modules/ng-packagr",
"//:node_modules/rxjs",
Expand Down Expand Up @@ -238,7 +236,6 @@ ts_project(
"//:node_modules/@angular/compiler-cli",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//:node_modules/@angular/platform-browser-dynamic",
"//:node_modules/@angular/router",
"//:node_modules/rxjs",
"//:node_modules/tslib",
Expand Down
4 changes: 4 additions & 0 deletions packages/angular/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"@angular/compiler": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/compiler-cli": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/localize": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/platform-browser": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/platform-server": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/service-worker": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/ssr": "^0.0.0-PLACEHOLDER",
Expand All @@ -74,6 +75,9 @@
"@angular/localize": {
"optional": true
},
"@angular/platform-browser": {
"optional": true
},
"@angular/platform-server": {
"optional": true
},
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/build/src/builders/application/tests/options/app-shell_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ const appShellRouteFiles: Record<string, string> = {
export class AppServerModule {}
`,
'src/main.ts': `
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';

platformBrowserDynamic().bootstrapModule(AppModule).catch(err => console.log(err));
platformBrowser().bootstrapModule(AppModule).catch(err => console.log(err));
`,
'src/app/app-routing.module.ts': `
import { NgModule } from '@angular/core';
Expand Down
9 changes: 4 additions & 5 deletions packages/angular/build/src/builders/karma/polyfills/init_test_bed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
*/

import { getTestBed } from '@angular/core/testing';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule } from '@angular/platform-browser/testing';

// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
// Initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), {
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
});
1 change: 0 additions & 1 deletion packages/angular_devkit/build_angular/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,6 @@ LARGE_SPECS = {
"//:node_modules/@angular/compiler-cli",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//:node_modules/@angular/platform-browser-dynamic",
"//:node_modules/@angular/router",
"//:node_modules/rxjs",
"//:node_modules/tslib",
Expand Down
4 changes: 4 additions & 0 deletions packages/angular_devkit/build_angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"peerDependencies": {
"@angular/compiler-cli": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/localize": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/platform-browser": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/platform-server": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/service-worker": "0.0.0-ANGULAR-FW-PEER-DEP",
"@angular/ssr": "^0.0.0-PLACEHOLDER",
Expand All @@ -92,6 +93,9 @@
"@angular/localize": {
"optional": true
},
"@angular/platform-browser": {
"optional": true
},
"@angular/platform-server": {
"optional": true
},
Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/builders/app-shell/app-shell_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ describe('AppShell Builder', () => {
export class AppServerModule {}
`,
'src/main.ts': `
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';

document.addEventListener('DOMContentLoaded', () => {
platformBrowserDynamic().bootstrapModule(AppModule)
platformBrowser().bootstrapModule(AppModule)
.catch(err => console.log(err));
});
`,
Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/builders/browser/specs/rebuild_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ describe('Browser Builder rebuilds', () => {
export let X = '$$_E2E_GOLDEN_VALUE_2';
`,
'src/main.ts': `
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';

platformBrowserDynamic().bootstrapModule(AppModule);
platformBrowser().bootstrapModule(AppModule);

import * as m from './app/app.module';
console.log(m.X);
Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/builders/browser/specs/web-worker_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ describe('Browser Builder Web Worker support', () => {
});
`,
'src/main.ts': `
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';
platformBrowserDynamic().bootstrapModule(AppModule).catch(err => console.error(err));
platformBrowser().bootstrapModule(AppModule).catch(err => console.error(err));

const worker = new Worker(new URL('./app/app.worker', import.meta.url), { type: 'module' });
worker.onmessage = ({ data }) => {
Expand Down
9 changes: 4 additions & 5 deletions packages/angular_devkit/build_angular/src/builders/jest/init-test-bed.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@
// `@angular-devkit/build-angular` rather than the user's workspace. Should look into virtual modules to support those use cases.

import { getTestBed } from '@angular/core/testing';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule } from '@angular/platform-browser/testing';

getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), {
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
});
9 changes: 4 additions & 5 deletions packages/angular_devkit/build_angular/src/builders/karma/browser_builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,12 @@ function getBuiltInMainFile(): string {
const content = Buffer.from(
`
import { getTestBed } from '@angular/core/testing';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';

// TODO(alanagius): replace with \`platformBrowserTesting\` once https://github.com/angular/angular/pull/60480 is released.
// Initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), {
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true
});
Expand Down
9 changes: 4 additions & 5 deletions packages/angular_devkit/build_angular/src/builders/web-test-runner/jasmine_runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@
*/

import { getTestBed } from '@angular/core/testing';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule } from '@angular/platform-browser/testing';
import {
getConfig,
sessionFailed,
Expand Down Expand Up @@ -67,7 +65,8 @@ export async function runJasmineTests(jasmineEnv) {
jasmine.DEFAULT_TIMEOUT_INTERVAL = config.defaultTimeoutInterval;

// Initialize `TestBed` automatically for users. This assumes we already evaluated `zone.js/testing`.
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), {
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
});
Expand Down
1 change: 0 additions & 1 deletion packages/angular_devkit/build_webpack/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ jasmine_test(
"//:node_modules/@angular/compiler-cli",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//:node_modules/@angular/platform-browser-dynamic",
"//:node_modules/tslib",
"//:node_modules/typescript",
"//:node_modules/zone.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_webpack/test/angular-app/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* found in the LICENSE file at https://angular.dev/license
*/

import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';

platformBrowserDynamic()
platformBrowser()
.bootstrapModule(AppModule)
.catch((err) => console.log(err));
1 change: 0 additions & 1 deletion packages/schematics/angular/workspace/files/package.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"@angular/core": "<%= latestVersions.Angular %>",
"@angular/forms": "<%= latestVersions.Angular %>",
"@angular/platform-browser": "<%= latestVersions.Angular %>",
"@angular/platform-browser-dynamic": "<%= latestVersions.Angular %>",
"@angular/router": "<%= latestVersions.Angular %>",
"rxjs": "<%= latestVersions['rxjs'] %>",
"tslib": "<%= latestVersions['tslib'] %>",
Expand Down
21 changes: 0 additions & 21 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion tests/legacy-cli/e2e/assets/ssr-project-webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"@angular/core": "^20.0.0-next.0",
"@angular/forms": "^20.0.0-next.0",
"@angular/platform-browser": "^20.0.0-next.0",
"@angular/platform-browser-dynamic": "^20.0.0-next.0",
"@angular/platform-server": "^20.0.0-next.0",
"@angular/router": "^20.0.0-next.0",
"@angular/ssr": "^20.0.0-next.0",
Expand Down
6 changes: 2 additions & 4 deletions tests/legacy-cli/e2e/assets/ssr-project-webpack/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';

import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';


platformBrowserDynamic().bootstrapModule(AppModule)
platformBrowser().bootstrapModule(AppModule)
.catch(err => console.error(err));
4 changes: 2 additions & 2 deletions tests/legacy-cli/e2e/tests/build/server-rendering/express-engine-ngmodule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ export default async function () {
'projects/test-project-two/src/app/app.css': `div { color: #000 }`,
'projects/test-project-two/src/styles.css': `* { color: #000 }`,
'projects/test-project-two/src/main.ts': `
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { platformBrowser } from '@angular/platform-browser';
import { AppModule } from './app/app.module';

(window as any)['doBootstrap'] = () => {
platformBrowserDynamic()
platformBrowser()
.bootstrapModule(AppModule)
.catch((err) => console.error(err));
};
Expand Down