Simplify approach for creating dag run and task spans#62554
Open
dstandish wants to merge 38 commits intoapache:mainfrom
Open
Simplify approach for creating dag run and task spans#62554dstandish wants to merge 38 commits intoapache:mainfrom
dstandish wants to merge 38 commits intoapache:mainfrom
Conversation
xBis7
reviewed
Feb 27, 2026
xBis7
reviewed
Feb 27, 2026
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py
Outdated
Show resolved
Hide resolved
74b3942 to
236e5ee
Compare
ashb
reviewed
Mar 3, 2026
a1cb165 to
a85b5eb
Compare
xBis7
reviewed
Mar 5, 2026
Contributor
There was a problem hiding this comment.
@dstandish Great job! I left some comments but generally it looks good and I think it can be converted to an actual PR.
Additionally, I tested it manually and I ran a dag with long timeouts. I didn't see any issues.
a7766b3 to
7e0a97e
Compare
integration tests fix static check test fix? try fix int test fix test fix tests fix tests fix integration test fix tests pre-commit
This reverts commit f453689.
d138440 to
a5edfd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace otel spans tracking implementation with something much simpler
rip out Trace, _TraceMeta, DebugTrace "classes"--> laterremove the "Tracer" protocol and EmptyTrace--> laterdeprecate the OtelTrace class