-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Simplify approach for creating dag run and task spans #62554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dstandish
wants to merge
39
commits into
apache:main
Choose a base branch
from
astronomer:minimize-otel-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+551
−1,205
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
64a8ca0
Remove the unnecessary OTEL tracing abstractions
dstandish a9f48e4
add dagrun span
dstandish 10adf1e
remove the base tracer class
dstandish eb93f08
simplify carrier
dstandish 18513d0
add task span
dstandish 3e1e172
guard around force flush
dstandish 575bce7
get it working again
dstandish 176e565
revert removals and deprecations of old otel code
dstandish 10bedbc
remove todo
dstandish 37b0e36
handle backcompat
dstandish e6da739
revert comment
dstandish f25aa1c
revert change
dstandish 0f3a5dd
add comment about backcompat config
dstandish eee3202
small fixes
dstandish 6e748c9
remove old testing
dstandish 0a58fc7
add dag run tracing tests
dstandish 988ecfc
add task runner span tests
dstandish c3e2d1a
review nits
dstandish 3b3a75d
make configure_otel a no-op when otel_on is off
dstandish 41e0df3
review nits
dstandish d5a5558
simplify id gen
dstandish 0552f8f
can set the context carrier earlier
dstandish 20e78cc
fix test
dstandish 8e3608d
fixes
dstandish 9a84061
type hint for carrier
dstandish 69cfa73
Integration test fix
dstandish 81a40d9
fixes
dstandish cdfc661
don't override span id
dstandish 773d324
Revert "don't override span id"
dstandish a90b062
use non-recording span to avoid memory leak, and move to helper function
dstandish 477aa33
fixes
dstandish e1e55f7
fix off by 1
dstandish d7fbb4a
update span names
dstandish 504ac3e
add config for flush timeout millis
dstandish 58279c6
tweak attr names
dstandish c33482a
fix tests
dstandish 76f122b
fix test
dstandish b909fdd
spelling
dstandish b4166e7
christos suggestion
dstandish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In another config we use the full word “milliseconds” so this should match. That’s the only place we use milliseconds though; elsewhere we always use seconds instead.