GH-48019 : [C++][FlightRPC] work-in-progress Enable ODBC in MSVC CI #48067
+419
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alinaliBQ
changed the title
Contributor
Author
|
Please note that I created this WIP PR to test the CI since Arrow's repo allows for longer runs |
alinaliBQ
force-pushed
the
gh-48019-build-odbc-msvc
branch
from
354f731 to
7349d67
Compare
This was referenced Nov 10, 2025
Having static vs. shared issue
To make it easier to manage dependencies
windows-mingw also has timeout of 2hr
* reason: gtest can't be used with C++17. Arrow project doesn't support C++ 17 yet.
* Add back `CMAKE_CXX_STANDARD: "17"`
Borrowed from the Glib workflow
`ARROW_BOOST_USE_SHARED` is restored to `OFF`, which according to Windows doc should help with the debug build now. Retore value of `ARROW_BUILD_BENCHMARKS`, though noting it is set to `OFF` in GLib MSVC workflow.
Getting ``` orc.lib(Exceptions.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in unity_2_cxx.cxx.obj orc.lib(Exceptions.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in unity_2_cxx.cxx.obj ``` when building with debug and presumably ARROW_ORC
Since we have a release build, can enable boost as shared. With `ARROW_BOOST_USE_SHARED = OFF`, I am getting error ``` D:\a\arrow\arrow\build\cpp\vcpkg_installed\x64-windows\include\boost/filesystem/config.hpp(96): fatal error C1189: #error: Must not define both BOOST_FILESYSTEM_DYN_LINK and BOOST_FILESYSTEM_STATIC_LINK ``` Also increased time limit, since 2 hours don't seem to be enough to finish the vcpkg build
Since we need to use link to boost dynamically, we need to remove the bundled boost library flag. Add debug messages.
Addresses comment apache#40939 (comment) Replace boost::optional with std::optional in ODBC codebase apache#48084 Fix lint
Attempt to include Arrow headers before ODBC headers to avoid conflict with arrow/flight/sql/types.h
To avoid redefinition error
…fo.cc` On some workflows, unity build is set to ON to make the build faster. This is an attempt to resolve the build issue.
I think `if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static")` might be more appropriate here, as I am seeing build issues due to both dynamic and static linking occurring. I see in apache@59903d0, this check is used for `arrow-filesystem-s3fs-benchmark`
On my local MSVC Windows machine, Visual Studio is used to build without needing to link ` ${ODBCINST}` explicitly, its behavior might be different from Ninja which is what CI uses.
`${ODBCINST}` is likely needed by Linux as well, so adding it for all platforms.
Use `arrow_flight_sql_odbc.dll` instead of `libarrow_flight_sql_odbc.dll` which is the naming convention used on MinGW Windows
Since we are installing dependencies on vcpkg, if `lib/cmake` is searched first, then cmake will look into that directory and use the wrong paths.
alinaliBQ
force-pushed
the
gh-48019-build-odbc-msvc
branch
from
11a2ab8 to
97b30d2
Compare
If ODBC test is run using MinGW Shell, segfault occurs. I am not getting any seg fault on my local MSVC Windows when I run the tests without the bash script. But if Windows CI breaks from running the standalone exe then I will look into this
Still need to modify ODBCUtilEnvironment if we decide to use it. Still need to add ODBC V2 support so a different env and conn is used for ODBC 2 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Enable ODBC in MSVC CI and disable ODBC in MinGW CI since MSVC is the main platform for ODBC.
What changes are included in this PR?
.github/workflows/cpp_windows.ymlboost-optionalas it blocks ODBC from building in MSVCSqlInfoOptionsAre these changes tested?
Tested in CI
Are there any user-facing changes?
N/A
SparseUnionTypedestructor when arrow.dll is unloaded via ODBC driver manager #48019