feat: Add aggregate expression fuzz testing in CI #1374
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
=============================================
- Coverage 56.12% 39.17% -16.95%
- Complexity 976 2065 +1089
=============================================
Files 119 262 +143
Lines 11743 60327 +48584
Branches 2251 12836 +10585
=============================================
+ Hits 6591 23635 +17044
- Misses 4012 32221 +28209
- Partials 1140 4471 +3331 ☔ View full report in Codecov by Sentry. |
| // ok | ||
| } else { | ||
|
|
||
| def almostEqual(a: Double, b: Double, tolerance: Double = 1e-6f): Boolean = { |
There was a problem hiding this comment.
Looks like there are multiple identical definitions of almostEqual?
There was a problem hiding this comment.
Yes, the code is hacky and experimental. Will clean up before marking as ready for review.
There was a problem hiding this comment.
Actually, the two implementations of almostEqual have different input types (float vs double).
| // ok | ||
| } else { | ||
|
|
||
| def almostEqual(a: Double, b: Double, tolerance: Double = 1e-6f): Boolean = { |
There was a problem hiding this comment.
Same implementation as above
|
|
||
| val scanTypes = Seq( | ||
| CometConf.SCAN_NATIVE_COMET | ||
| /*CometConf.SCAN_NATIVE_DATAFUSION, |
There was a problem hiding this comment.
Do we plan to have these scan implementations also added to the fuzz testing at some point?
There was a problem hiding this comment.
Yes. These are commented out for now because they fail due to timestamp issues.
andygrove
changed the title
Which issue does this PR close?
Part of #1345
Rationale for this change
We want to add randomized testing to help prevent regressions and increase test coverage.
What changes are included in this PR?
How are these changes tested?
New test, enabled in CI.