-
Notifications
You must be signed in to change notification settings - Fork 221
fix: enable full decimal to decimal support #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable full decimal to decimal support #1385
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
============================================
+ Coverage 56.12% 58.93% +2.80%
- Complexity 976 1028 +52
============================================
Files 119 122 +3
Lines 11743 12278 +535
Branches 2251 2311 +60
============================================
+ Hits 6591 7236 +645
+ Misses 4012 3883 -129
- Partials 1140 1159 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, thank you @himadripal just minor comments
Apologies for the late review @himadripal. I checked out the branch locally and ran some additional manual testing and could not find any issues. I left a comment about a missing assertion. Could you also rebase against main since this has been pending for a while? It would be great to get this into the 0.7.0 release next week if possible. |
use a regex to match arrow invalid argument error.
… double to decimal and few others paths still uses spark, hence generates spark error message.
5cce0c4
to
a4d298f
Compare
@andygrove I did not see this comment. Although I reverted previous changes related to spark3.3 assertion and added a check for specific messages for decimal to decimal conversion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending ci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @himadripal
Merged thanks @himadripal @andygrove @parthchandra |
Closes #375
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?