Skip to content

FINERACT-2533: Remove @Skip tags from savings account E2E scenarios#5737

Open
awaneetdecoder wants to merge 1 commit intoapache:developfrom
awaneetdecoder:FINERACT-2533-unskip-savings-scenarios
Open

FINERACT-2533: Remove @Skip tags from savings account E2E scenarios#5737
awaneetdecoder wants to merge 1 commit intoapache:developfrom
awaneetdecoder:FINERACT-2533-unskip-savings-scenarios

Conversation

@awaneetdecoder
Copy link
Copy Markdown
Contributor

Removes @Skip annotations from scenarios C2438, C2439, and C2440 in SavingsAccount.feature.

These scenarios were skipped because SavingsAccountRequestFactory hardcoded
EUR_SAVING_PRODUCT_ID = 1L which did not exist in the E2E environment.

PR #5646 fixed the root cause by dynamically creating the EUR savings product via
SavingsProductRequestFactory.defaultSavingsProductRequest() and storing its ID in
TestContextKey.DEFAULT_SAVINGS_PRODUCT_CREATE_RESPONSE_EUR.

The "And Admin creates a EUR savings product" step is now added to C2438, C2439,
and C2440 (already present in C2441 from PR #5646), making the skip reason obsolete.

Closes FINERACT-2533

@awaneetdecoder
Copy link
Copy Markdown
Contributor Author

@adamsaghy As requested, removed the @Skip tags from C2438, C2439, and C2440.
Added the "And Admin creates a EUR savings product" step to each scenario to
dynamically create the product, same approach as C2441 in PR #5646.

@awaneetdecoder awaneetdecoder force-pushed the FINERACT-2533-unskip-savings-scenarios branch from 274bf6c to 693cdcf Compare April 3, 2026 12:51
@awaneetdecoder
Copy link
Copy Markdown
Contributor Author

@adamsaghy During CI, scenarios C2439, C2440, and C2441 were failing with a 403
"Unknown data integrity issue with savings product" error. The root cause was that
SavingsProductRequestFactory.defaultSavingsProductRequest() used a hardcoded product
name "CEUR" — when multiple scenarios run sequentially in the same DB session, the
second scenario hits a unique constraint violation trying to create a product with
the same name.

Fixed by appending a 4-character UUID suffix to both the product name and short name,
making each scenario's product creation independent. All 43 checks are now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant