Skip to content

FINERACT-2533: Remove @Skip tags from savings account E2E scenarios #5737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsaghy merged 1 commit into from
Apr 6, 2026
+10 −7
Merged

FINERACT-2533: Remove @Skip tags from savings account E2E scenarios #5737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...sts-core/src/test/java/org/apache/fineract/test/factory/SavingsProductRequestFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@

import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import org.apache.fineract.client.models.PostSavingsCharges;
import org.apache.fineract.client.models.PostSavingsProductsRequest;

public final class SavingsProductRequestFactory {

public static final String DEFAULT_SAVINGS_PRODUCT_NAME = "CEUR";

public static final String DEFAULT_SAVINGS_PRODUCT_SHORT_NAME = "CEU";
public static final String DEFAULT_SAVINGS_PRODUCT_DESCRIPTION = "";
public static final String DEFAULT_SAVINGS_PRODUCT_CURRENCY_CODE = "EUR";
Expand All @@ -43,10 +43,11 @@ public final class SavingsProductRequestFactory {
private SavingsProductRequestFactory() {}

public static PostSavingsProductsRequest defaultSavingsProductRequest() {
String uniqueId = UUID.randomUUID().toString().replace("-", "").substring(0, 4).toUpperCase();
List<PostSavingsCharges> charges = new ArrayList<>();

return new PostSavingsProductsRequest().name(DEFAULT_SAVINGS_PRODUCT_NAME)//
.shortName(DEFAULT_SAVINGS_PRODUCT_SHORT_NAME)//
return new PostSavingsProductsRequest().name(DEFAULT_SAVINGS_PRODUCT_NAME + "-" + uniqueId)//
.shortName(uniqueId)//
.description(DEFAULT_SAVINGS_PRODUCT_DESCRIPTION)//
.currencyCode(DEFAULT_SAVINGS_PRODUCT_CURRENCY_CODE)//
.digitsAfterDecimal(DEFAULT_SAVINGS_PRODUCT_DIGITS_AFTER_DECIMAL)//
Expand Down
10 changes: 6 additions & 4 deletions fineract-e2e-tests-runner/src/test/resources/features/SavingsAccount.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,32 @@
@SavingsAccount
Feature: SavingsAccount

# TODO unskip and check when PS-1088 is done
@Skip @TestRailId:C2438
@TestRailId:C2438
Scenario: As a user I would like to Deposit to my savings account
When Admin sets the business date to "1 June 2022"
When Admin creates a client with random data
And Admin creates a EUR savings product
And Client creates a new EUR savings account with "1 June 2022" submitted on date
And Approve EUR savings account on "1 June 2022" date
And Activate EUR savings account on "1 June 2022" date
And Client successfully deposits 1000 EUR to the savings account on "1 June 2022" date

@Skip @TestRailId:C2439
@TestRailId:C2439
Scenario: As a user I would like to Withdraw from my savings account
When Admin sets the business date to "1 June 2022"
When Admin creates a client with random data
And Admin creates a EUR savings product
And Client creates a new EUR savings account with "1 June 2022" submitted on date
And Approve EUR savings account on "1 June 2022" date
And Activate EUR savings account on "1 June 2022" date
And Client successfully deposits 1000 EUR to the savings account on "1 June 2022" date
And Client successfully withdraw 1000 EUR from the savings account on "1 June 2022" date

@Skip @TestRailId:C2440
@TestRailId:C2440
Scenario: As a user I would like to create an EUR and USD Savings accounts and make deposit and withdraw events
When Admin sets the business date to "1 June 2022"
When Admin creates a client with random data
And Admin creates a EUR savings product
And Client creates a new EUR savings account with "1 June 2022" submitted on date
And Approve EUR savings account on "1 June 2022" date
And Activate EUR savings account on "1 June 2022" date
Expand Down
Loading