Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 #6783

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 #6783

wants to merge 1 commit into from

Conversation

NihalJain
Copy link
Contributor

@NihalJain NihalJain commented Mar 11, 2025 •
edited
Loading

  • Also consume hbase-thridparty having the new jetty 12 ee8 module

Refer discussion at https://lists.apache.org/thread/bkrfm705kqd3bqzyvo7jv46t6p64x2n5

@NihalJain
[WIP] Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1
cceaf51 
- Also consume hbase-thridparty having the new jetty 12 ee8 module
@NihalJain NihalJain marked this pull request as draft March 11, 2025 20:31
@NihalJain
Copy link
Contributor Author

Link: apache/hbase-thirdparty#131

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java
@@ -796,7 +792,7 @@ private void configureAliasChecks(ServletContextHandler context, boolean shouldS
if (context.getAliasChecks().stream().anyMatch(aliasCheckerClass::isInstance)) {
LOG.debug("{} is already part of alias check list", aliasCheckerClass.getName());
} else {
context.addAliasCheck(new SymlinkAllowedResourceAliasChecker(context));
context.addAliasCheck(new SymlinkAllowedResourceAliasChecker(context.getCoreContextHandler()));
Copy link
Contributor Author

@NihalJain NihalJain Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log folder is broken if we have a relative path, I suspect it is a jetty bug, may need to check more. Works fine for absolute path, otherwise fails similar to https://www.eclipse.org/lists/jetty-users/msg10296.html

404
Not Found
org.apache.hadoop.hbase.http.AdminAuthorizedServlet-5aae8eb5

So basically it works fine if log directory is "/a/b/c/logs" but fails with 404 if it is "/a/b/c/d/../logs".

Need to figure this out!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jetty/jetty.project#12833 might help?

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java
@@ -151,6 +154,32 @@ void clearRegistrations() {
}

@Override
public boolean handle(org.apache.hbase.thirdparty.org.eclipse.jetty.server.Request request, Response response, Callback callback) throws Exception {
Copy link
Contributor Author

@NihalJain NihalJain Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Don't think the changes made in this file are correct. Will check later!

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/NamespacesResource.java
@@ -71,7 +71,7 @@ public Response get(final @Context ServletContext context, final @Context UriInf
return Response.ok(rowModel).build();
} catch (IOException e) {
servlet.getMetrics().incrementFailedGetRequests(1);
throw new RuntimeException("Cannot retrieve list of namespaces.");
throw new RuntimeException("Cannot retrieve list of namespaces.", e);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo change

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
...shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
@@ -96,6 +96,8 @@ allowed_expr+="|^PropertyList-1.0.dtd$"
# Shaded jetty resources
allowed_expr+="|^about.html$"
allowed_expr+="|^jetty-dir.css$"
# Required by jetty 12 on ee8
Copy link
Contributor Author

@NihalJain NihalJain Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do this to include xsd file in javax/servlet/resources coming from org.apache.hbase.thirdparty:hbase-shaded-jetty-ee8. Else if we exclude the folder in thirdparty starting hbase fails with following:

2025-03-10T13:02:47,631 ERROR [main] master.HMasterCommandLine: Master exiting
java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMasternull
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:128) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:224) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.LocalHBaseCluster.<init>(LocalHBaseCluster.java:171) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.LocalHBaseCluster.<init>(LocalHBaseCluster.java:114) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:241) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:147) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) ~[hadoop-common-3.4.1.jar:?]
	at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:140) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3489) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
Caused by: java.io.IOException: Unable to initialize WebAppContext
	at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1230) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?]
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	... 8 more
Caused by: java.lang.ExceptionInInitializerError
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebXmlConfiguration.preConfigure(WebXmlConfiguration.java:61) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.Configurations.preConfigure(Configurations.java:407) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.preConfigure(WebAppContext.java:470) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.doStart(WebAppContext.java:500) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1452) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2271) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:132) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.start(Server.java:641) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:582) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1209) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?]
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	... 8 more
Caused by: java.lang.IllegalStateException: Unable to instantiate WebDescriptorParser
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.newParser(WebDescriptor.java:89) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.<clinit>(WebDescriptor.java:37) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebXmlConfiguration.preConfigure(WebXmlConfiguration.java:61) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.Configurations.preConfigure(Configurations.java:407) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.preConfigure(WebAppContext.java:470) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.doStart(WebAppContext.java:500) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1452) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2271) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:132) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.start(Server.java:641) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:582) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1209) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?]
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	... 8 more
Caused by: java.io.FileNotFoundException: Unable to find ref [javax/servlet/resources/javaee_8.xsd] in same archive as javax.servlet.Servlet: file:/Users/nihjain/code/os/temp2/hbase/hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.servlet-api-3.1.0.jar
	at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.BaseClassCatalog$CatalogReader.getMapping(BaseClassCatalog.java:112) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.BaseClassCatalog$CatalogReader.parse(BaseClassCatalog.java:84) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.BaseClassCatalog.load(BaseClassCatalog.java:56) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.xml.XmlParser.addCatalog(XmlParser.java:220) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor$WebDescriptorParser.<init>(WebDescriptor.java:101) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.newParser(WebDescriptor.java:87) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebDescriptor.<clinit>(WebDescriptor.java:37) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebXmlConfiguration.preConfigure(WebXmlConfiguration.java:61) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.Configurations.preConfigure(Configurations.java:407) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.preConfigure(WebAppContext.java:470) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.webapp.WebAppContext.doStart(WebAppContext.java:500) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:113) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.lambda$doStart$0(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1452) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:754) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.ee8.nested.ContextHandler$CoreContextHandler.doStart(ContextHandler.java:2271) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:132) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.start(Server.java:641) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:582) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) ~[hbase-shaded-jetty-ee8-4.1.11-SNAPSHOT.jar:?]
	at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1209) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:157) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:350) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:522) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.<init>(HMasterCommandLine.java:322) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?]
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
	... 8 more

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
pom.xml
@@ -863,9 +863,9 @@
<jackson.version>2.17.2</jackson.version>
<jackson.databind.version>2.17.2</jackson.databind.version>
<jaxb-api.version>2.3.1</jaxb-api.version>
<servlet.api.version>3.1.0</servlet.api.version>
<servlet.api.version>4.0.1</servlet.api.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hbase worked with 3.1.0 as well but as per https://stackoverflow.com/questions/77007560/missing-jetty-servlet-12-0-0-dependency we should be on 4.x

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
pom.xml
<!-- for.exclusion version are NOT for direct dependencies. To use the provided
scope to transitively exclude some transitive dependencies, we need to specify
some existing version to for maven. -->
<tomcat.version.for.exclusion>9.0.93</tomcat.version.for.exclusion>
<tomcat.version.for.exclusion>${tomcat.jasper.version}</tomcat.version.for.exclusion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: fix existing comment, we actually depend on tomcat in hbase

NihalJain
NihalJain commented Mar 11, 2025
View reviewed changes
hbase-it/src/test/java/org/apache/hadoop/hbase/MockHttpApiRule.java
return true;
}

//@Override
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah drop old version

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 9s master passed
+1 💚 compile 2m 34s master passed
+1 💚 javadoc 4m 28s master passed
+1 💚 shadedjars 6m 1s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 12s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 9s /patch-compile-root.txt root in the patch failed.
-0 ⚠️ javac 0m 9s /patch-compile-root.txt root in the patch failed.
-0 ⚠️ javadoc 0m 9s /patch-javadoc-root.txt root in the patch failed.
-0 ⚠️ javadoc 0m 9s /patch-javadoc-hbase-http.txt hbase-http in the patch failed.
-0 ⚠️ javadoc 0m 7s /patch-javadoc-hbase-it.txt hbase-it in the patch failed.
-0 ⚠️ javadoc 0m 8s /patch-javadoc-hbase-rest.txt hbase-rest in the patch failed.
-0 ⚠️ javadoc 0m 7s /patch-javadoc-hbase-server.txt hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 7s /patch-javadoc-hbase-thrift.txt hbase-thrift in the patch failed.
-1 ❌ shadedjars 0m 13s patch has 23 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 0m 10s /patch-unit-root.txt root in the patch failed.
20m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6783
Optional Tests javac javadoc unit shadedjars compile
uname Linux 591b61cbbd64 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cceaf51
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/testReport/
Max. process+thread count 172 (vs. ulimit of 30000)
modules C: . hbase-http hbase-it hbase-rest hbase-server hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 11s master passed
+1 💚 compile 7m 54s master passed
+1 💚 checkstyle 1m 10s master passed
+1 💚 spotbugs 11m 29s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 10s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 12s /patch-compile-root.txt root in the patch failed.
-0 ⚠️ javac 0m 12s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 5s /buildtool-patch-checkstyle-root.txt The patch fails to run checkstyle in root
+1 💚 shellcheck 0m 2s No new issues.
+1 💚 xmllint 0m 0s No new issues.
-1 ❌ spotbugs 0m 12s /patch-spotbugs-root.txt root in the patch failed.
-1 ❌ spotbugs 0m 8s /patch-spotbugs-hbase-http.txt hbase-http in the patch failed.
-1 ❌ spotbugs 0m 7s /patch-spotbugs-hbase-it.txt hbase-it in the patch failed.
-1 ❌ spotbugs 0m 8s /patch-spotbugs-hbase-rest.txt hbase-rest in the patch failed.
-1 ❌ spotbugs 0m 6s /patch-spotbugs-hbase-server.txt hbase-server in the patch failed.
-1 ❌ spotbugs 0m 6s /patch-spotbugs-hbase-thrift.txt hbase-thrift in the patch failed.
-1 ❌ hadoopcheck 0m 9s The patch causes 13 errors with Hadoop v3.3.6.
-1 ❌ hadoopcheck 0m 16s The patch causes 13 errors with Hadoop v3.4.0.
-1 ❌ spotless 0m 16s patch has 35 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
30m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6783
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti shellcheck shelldocs
uname Linux c63d8bb61fa2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cceaf51
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 191 (vs. ulimit of 30000)
modules C: . hbase-http hbase-it hbase-rest hbase-server hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6783/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain NihalJain mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NihalJain @Apache-HBase