Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12828 support relative uris for Response.encodeURI #12833

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

janbartel
Copy link
Contributor

Closes #12828

Jetty throws IllegalArgumentException during Response.encodeURI for uris like ../.

This PR ensures we encode uris such as this correctly.

@janbartel janbartel requested a review from gregw February 28, 2025 09:30
@janbartel janbartel self-assigned this Feb 28, 2025
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@janbartel janbartel merged commit cab8d63 into jetty-12.0.x Feb 28, 2025
11 checks passed
@janbartel janbartel deleted the jetty-12.0.x-12828-encode-relative-uris branch February 28, 2025 17:04
@NihalJain
Copy link

Hi @janbartel I am seeing apache/hbase#6783 (comment), do you think this fix might help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

HttpServletResponse.encodeURL() does not support relative paths
3 participants