NUTCH-3144 URLUtil unit tests fail after upgrade to crawler-commons 1.6#881
Merged
sebastian-nagel merged 1 commit intoapache:masterfrom Jan 12, 2026
Merged
Conversation
Contributor
sebastian-nagel
commented
Jan 7, 2026
sebastian-nagel
commented
- adapt unit tests to changes introduced in [Domains] Improve representation of public suffix match results by class EffectiveTLD crawler-commons/crawler-commons#478
- test for example given in Javadoc of getDomainSuffix
- adapt unit tests to changes introduced in crawler-commons/crawler-commons#478 - test for example given in Javadoc of getDomainSuffix
Member
|
Ah ha! I actually came across this during #879 but thought it tangential. Nice catch. |
Contributor
Author
|
Thanks, @lewismc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.