Skip to content

NUTCH-3144 URLUtil unit tests fail after upgrade to crawler-commons 1.6 #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastian-nagel merged 1 commit into from
Jan 12, 2026
+3 −1
Merged

NUTCH-3144 URLUtil unit tests fail after upgrade to crawler-commons 1.6 #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/java/org/apache/nutch/util/URLUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public static String getDomainSuffix(URL url) {

EffectiveTldFinder.EffectiveTLD suffix = EffectiveTldFinder.getEffectiveTLD(host, true);
if (suffix != null) {
return suffix.getDomain();
return suffix.getSuffix();
}

return null;
Expand Down
2 changes: 2 additions & 0 deletions src/test/org/apache/nutch/util/TestURLUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ public void testGetDomainSuffix() throws Exception {
assertEquals("2000.hu", URLUtil.getDomainSuffix(url));

// test non-ASCII
url = new URL("https://www.taiuru.māori.nz/");
assertEquals("xn--mori-qsa.nz", URLUtil.getDomainSuffix(url));
url = new URL("http://www.example.flå.no");
assertEquals("xn--fl-zia.no", URLUtil.getDomainSuffix(url));
url = new URL("http://www.example.栃木.jp");
Expand Down