Skip to content

HDDS-12441. Add helper script for building Docker image#11

Merged
errose28 merged 4 commits intoapache:masterfrom
adoroszlai:HDDS-12441
Mar 5, 2025
Merged

HDDS-12441. Add helper script for building Docker image#11
errose28 merged 4 commits intoapache:masterfrom
adoroszlai:HDDS-12441

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add build.sh, helper script for building the image.

Benefits:

  • consistent experience across ozone-docker* repos
  • future improvements possible without updating docs

Also add .dockerignore.

https://issues.apache.org/jira/browse/HDDS-12441

How was this patch tested?

$ ./build.sh
...
 => => naming to docker.io/apache/ozone-testkrb5:dev

CI:
https://github.com/adoroszlai/ozone-docker-testkrb5/actions/runs/13588513265

Copy link
Copy Markdown

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Can we update the readme in this PR as well to reference the build script?

@adoroszlai
Copy link
Copy Markdown
Contributor Author

Can we update the readme in this PR as well to reference the build script?

Updated, similar to the one already merged for ozone-runner. Please take another look.

Copy link
Copy Markdown

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

@errose28 errose28 merged commit 6c1e43d into apache:master Mar 5, 2025
1 check passed
@adoroszlai adoroszlai deleted the HDDS-12441 branch March 5, 2025 19:21
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @errose28 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants