Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7221 Manage requests-gssapi version for Phython 3.7 and lower #147

Closed
wants to merge 2 commits into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Feb 27, 2024

No description provided.

@stoty stoty requested a review from richardantal February 27, 2024 06:51
'requests-gssapi',
'gssapi<1.6.0;python_version<"3.6"',
'requests-gssapi; python_version>="3.8.0"',
'requests-gssapi<1.30; python_version<"3.8.0"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be requests-gssapi<1.3.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Fixed.

@stoty stoty requested a review from richardantal February 27, 2024 16:06
Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty
Copy link
Contributor Author

stoty commented Feb 27, 2024

merged manually

@stoty stoty closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants