Skip to content

PHOENIX-7221 Manage requests-gssapi version for Phython 3.7 and lower #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

PHOENIX-7221 Manage requests-gssapi version for Phython 3.7 and lower #147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0550d5e
PHOENIX-7221 Manage requests-gssapi version for Phython 3.7 and lower
stoty Feb 27, 2024
59d60a1
fix typo in version
stoty Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions python-phoenixdb/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,17 @@ from <https://github.com/apache/phoenix-queryserver>

Extract the archive and then install it manually::

cd /path/to/phoenix-queryserver-x.y.z/python/phoenixdb
cd /path/to/phoenix-queryserver-x.y.z/python-phoenixdb
pip install -r requirements.txt
python setup.py install

Note that old versions of pip and setuptools have various bugs and incompatibilities that
may result in installation errors, especially on old python versions.
If you encounter problems while building, update your pip and setuptools, and try again::
pip install --upgrade pip
pip install --upgrade setuptools


Usage
-----

Expand Down Expand Up @@ -83,7 +90,7 @@ this will also create a shell script in phoenix-queryserver-it/target/krb_setup.
use to set up the environment for the tests.

Note: Depending on the Phoenix version used for building, you may or may not need the
`-Pshade-javax-servlet` option. Check BUILDING.md in the repository root.
`-Pshade-javax-servlet` option. See BUILDING.md in the repository root for more information.

If you want to use the library without installing the phoenixdb library, you can use
the `PYTHONPATH` environment variable to point to the library directly::
Expand Down
10 changes: 7 additions & 3 deletions python-phoenixdb/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ def readme():
install_requires=[
'protobuf>=3.0.0',
'requests',
'requests-gssapi',
]
if sys.version_info < (3,8):
install_requires.append('requests-gssapi<1.3.0')
else:
install_requires.append('requests-gssapi')
if sys.version_info < (3,6):
install_requires.append('gssapi<1.6.0')
#Don't build the docs on an old stack
Expand All @@ -50,8 +53,9 @@ def readme():
install_requires=[
'protobuf>=3.0.0',
'requests',
'requests-gssapi',
'gssapi<1.6.0;python_version<"3.6"',
'requests-gssapi; python_version>="3.8.0"',
'requests-gssapi<1.30; python_version<"3.8.0"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be requests-gssapi<1.3.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Fixed.

'gssapi<1.6.0; python_version<"3.6.0"',
]
setup_requires=[
'Sphinx;python_version>="3.6"',
Expand Down