PHOENIX-7430 Remove commons-collections dependency in queryserver #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NihalJain
commented
Oct 14, 2024
NihalJain
commented
- Also remove imports and replace with equivalent code
- Also remove imports and replace with equivalent code
NihalJain
commented
Oct 14, 2024
phoenix-queryserver/src/main/java/org/apache/phoenix/util/InstanceResolver.java
Show resolved
Hide resolved
NihalJain
commented
Oct 14, 2024
| @@ -723,12 +722,6 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
There was a problem hiding this comment.
We do not have restrict plugin in PQS. Should we add one here and sync all restricts or just add commons-collections restricts?
There was a problem hiding this comment.
It's up to you.
PQS has minimal code.
If you decide to add the restricions, then I think it's better to sync everything from the main repo.
There was a problem hiding this comment.
If you decide to add the restrictions, they could be handled in a separate JIRA.
There was a problem hiding this comment.
Yes make sense, let me raise another JIRA for same, this will keep changes in PR as per JIRA title
There was a problem hiding this comment.
Raised PHOENIX-7438
|
Hi @stoty, could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.