Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more inner classes to top-level classes #1106

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Move more inner classes to top-level classes #1106

merged 1 commit into from
Mar 11, 2025

Conversation

flyrain
Copy link
Contributor

@flyrain flyrain commented Mar 3, 2025

Similar to #1095.

@flyrain flyrain marked this pull request as ready for review March 3, 2025 21:53
singhpk234
singhpk234 reviewed Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, thanks @flyrain !

@jbonofre
Copy link
Member

jbonofre commented Mar 4, 2025

Overall it looks good to me. However, I would propose to wait a bit to see the outcome of the persistence work performed by @dennishuo and @snazy .

@flyrain
Copy link
Contributor Author

flyrain commented Mar 4, 2025

Overall it looks good to me. However, I would propose to wait a bit to see the outcome of the persistence work performed by @dennishuo and @snazy .

Hi @jbonofre , this is a pure refactor without any logic change, as a followup of #1095. And #1097 has been merged, it won't be conflict with this one.

@eric-maynard eric-maynard enabled auto-merge (squash) March 7, 2025 17:19
@flyrain flyrain force-pushed the more-dao-entity-refactor branch from 68f47c4 to 472f5bc Compare March 11, 2025 20:25
@eric-maynard eric-maynard merged commit 818cd00 into apache:main Mar 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhpk234 singhpk234 singhpk234 left review comments

@eric-maynard eric-maynard eric-maynard approved these changes

@collado-mike collado-mike collado-mike approved these changes

@HonahX HonahX HonahX approved these changes

@adutra adutra Awaiting requested review from adutra adutra is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@dennishuo dennishuo Awaiting requested review from dennishuo dennishuo is a code owner

@dimas-b dimas-b Awaiting requested review from dimas-b dimas-b is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@MonkeyCanCode MonkeyCanCode Awaiting requested review from MonkeyCanCode MonkeyCanCode is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flyrain @jbonofre @eric-maynard @singhpk234 @collado-mike @HonahX