Refactor Polaris cloudTests and adopt changes from PR #2405 #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
previously approved these changes
Oct 23, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for reviving this!
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
Author
Thank you for the quick review! 😊 |
dimas-b
reviewed
Oct 23, 2025
| extends PolarisRestCatalogIntegrationBase { | ||
| public static final String TENANT_ID = System.getenv("INTEGRATION_TEST_AZURE_TENANT_ID"); | ||
| public static final String BASE_LOCATION = System.getenv("INTEGRATION_TEST_AZURE_PATH"); | ||
| public static final String TENANT_ID = System.getenv("INTEGRATION_TEST_ADLS_TENANT_ID"); |
Contributor
There was a problem hiding this comment.
Renaming this will certainly break things that depend on it, but I haven't been involved with the latest guidelines on changes that break internal "interfaces", so I'd defer to what the status quo is.
Contributor
Author
There was a problem hiding this comment.
Thanks for looking into it @dimas-b & @andrew4699! Makes sense, reverted the env rename part.
adutra
approved these changes
Oct 27, 2025
dimas-b
approved these changes
Oct 27, 2025
Contributor
Author
|
Just checking if we’re good to merge, or if there’s anything else needed here. |
snazy
approved these changes
Nov 3, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Changes LGTM!
Let's get this in.
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch picks up changes from apache/polaris#2405.
It includes only the refactoring portions, as there have been updates to the
createViewWithCustomMetadataLocationUsingPolarisandcreateViewWithCustomMetadataLocationtests that require further investigation.Details
Integrated relevant refactors from upstream PR #2405, renaming classes, environment variables and making Base classes abstract.
Known Issues
The following tests are still failing in
cloudTest:createViewWithCustomMetadataLocationUsingPolariscreateViewWithCustomMetadataLocationThese will be investigated and fixed in a follow-up PR.
Testing
cloudTestslocally to validate refactor integrity.