Skip to content

Conversation

@XN137
Copy link
Contributor

@XN137 XN137 commented Oct 29, 2025

it should not be the responsibility of the FileIOFactory to know how to infer the AccessConfig

Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable refactoring to me 👍 Thanks, @XN137 !

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Oct 29, 2025
@dimas-b dimas-b marked this pull request as ready for review October 29, 2025 21:08
it should not be the responsibility of the `FileIOFactory` to know how
to infer the `AccessConfig`
@XN137 XN137 force-pushed the Pass-AccessConfig-into-FileIOFactory branch from 2576528 to cf3b98a Compare October 30, 2025 07:18
@dimas-b dimas-b merged commit aedb724 into apache:main Nov 3, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 3, 2025
@XN137 XN137 deleted the Pass-AccessConfig-into-FileIOFactory branch November 3, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants