Make StorageAccessConfigProvider request-scoped #2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
force-pushed
the
request-scoped-AccessConfigProvider
branch
from
662a47e to
95cd2cf
Compare
dimas-b
reviewed
Nov 7, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
This PR LGTM as it stands 👍 but I wonder if we could take it one step further (as commented below) 🤔 WDYT?
| ? tableLocations | ||
| : Set.of(); | ||
| AccessConfig accessConfig = | ||
| storageCredentialCache.getOrGenerateSubScopeCreds( |
Contributor
There was a problem hiding this comment.
WDYT about making AccessConfigProvider and interface and hiding StorageCredentialCache in one of the implementations?
StorageCredentialCache will remain application-scoped, of course?
Contributor
Author
There was a problem hiding this comment.
i agree with splitting out an interface, however i think we should do it in a follow-up PR as its not directly related to the goal of this PR, wdyt?
Contributor
There was a problem hiding this comment.
Sure. A follow-up PR for this SGTM 👍
dimas-b
previously approved these changes
Nov 10, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
- add `StorageCredentialsVendor` as request-scoped wrapper around `PolarisCredentialVendor` - make `FileIOFactory` request-scoped - make `TaskFileIOSupplier` request-scoped
XN137
force-pushed
the
request-scoped-AccessConfigProvider
branch
from
95cd2cf to
ada4731
Compare
XN137
changed the title
Contributor
Author
|
rebased after conflict with aa72157 |
dimas-b
approved these changes
Nov 11, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
MonkeyCanCode
pushed a commit
to MonkeyCanCode/polaris
that referenced
this pull request
Nov 12, 2025
- add `StorageCredentialsVendor` as request-scoped wrapper around `PolarisCredentialVendor` - make `FileIOFactory` request-scoped - make `TaskFileIOSupplier` request-scoped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageCredentialsVendoras request-scoped wrapper aroundPolarisCredentialVendorFileIOFactoryrequest-scopedTaskFileIOSupplierrequest-scoped