added the new workflow that automatically puts the labels in PR #741
Conversation
|
Hi @Ronitsabhaya75 thanks for the contribution, this is super helpful! Looks like the labeler workflow failed due to some syntax errors in the configuration file. |
|
sure I can fix those issues thank you so much. |
|
@katiewasnothere can you please check now by run action |
.github/labeler.yml
Outdated
| "area: build": | ||
| - Sources/ContainerBuild/**/* | ||
| - Makefile | ||
| - Package.swift | ||
| - Package.resolved | ||
| - Protobuf.Makefile |
There was a problem hiding this comment.
I think this area is accidentally a combination of container image builder components, project building components, and project dependencies. A large majority of PRs will likely either modify the makefiles or the Package.* files, so I think we can exclude those files from a label category to avoid extra noise.
We should change this to:
area:builder for code related to image building. That would include
- Sources/ContainerBuild//*
- Sources/NativeBuilder//*
.github/labeler.yml
Outdated
| "tooling": | ||
| - scripts/**/* | ||
| - licenserc.toml | ||
| - Makefile | ||
| - Protobuf.Makefile |
There was a problem hiding this comment.
Same as my comment above, I think we can remove this category entirely.
.github/labeler.yml
Outdated
| # Dependencies | ||
| "dependencies": | ||
| - Package.swift | ||
| - Package.resolved |
There was a problem hiding this comment.
Same as my comment above, I think we can remove this category entirely.
.github/labeler.yml
Outdated
| "c/c++": | ||
| - Sources/CVersion/**/* | ||
| - "**/*.c" | ||
| - "**/*.h" |
There was a problem hiding this comment.
Curious what others think here, but I think this category is possibly too small to be useful. We have very little c code and I don't think anyone would really use this label to find or search for PRs.
|
can you give me what category i can put right now instead of all then once it starts for some catgeory then we can add basically rest basically start from small to big |
.github/labeler.yml
Outdated
| # Configuration | ||
| "configuration": | ||
| - config/**/* | ||
| - "**/*.json" | ||
| - "**/*.toml" | ||
| - signing/**/* |
There was a problem hiding this comment.
I'm not sure we need this category
@Ronitsabhaya75 sure thing. I think the easiest category would be the CLI one. So you could remove all of them except that one for now while we get this running. |
sure once I got time after my interview i can fix this thing |
|
@katiewasnothere I have changed to CLI only now we check if this works then we can merge |
2 participants
Type of Change
@dcantah can you please review this pr and suggest me if any changes require