Skip to content

added the new workflow that automatically puts the labels in PR #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+42 −0
Open

added the new workflow that automatically puts the labels in PR #741

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4874f75
adding the new labeler yml that explicilty gives labels and help the …
Oct 8, 2025
226a087
Fix repository name in workflow conditions
Oct 8, 2025
f5a5b4f
Remove workflow dispatch step from labeler - PR build no longer accep…
Oct 8, 2025
d4ba2ee
reseting things to apple again
Oct 8, 2025
ebd33c7
Updated the paths for file configuration ( seek advice from AI )
Oct 9, 2025
18e6429
Merge branch 'main' into main
Ronitsabhaya75 Oct 9, 2025
6c935bb
Merge branch 'apple:main' into main
Ronitsabhaya75 Oct 11, 2025
3193fce
Updated the labler.yml to only CLI
Oct 11, 2025
e772530
Merge branch 'main' into main
Ronitsabhaya75 Oct 13, 2025
f06eb4f
Merge branch 'main' into main
Ronitsabhaya75 Oct 14, 2025
8330c78
Merge branch 'main' into main
Ronitsabhaya75 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
# Configuration for automatic PR labeling based on file changes
# https://github.com/actions/labeler

# Core areas
"area: cli":
- Sources/CLI/**/*
- Sources/ContainerCommands/**/*

"area: build":
- Sources/ContainerBuild/**/*
- Makefile
- Package.swift
- Package.resolved
- Protobuf.Makefile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this area is accidentally a combination of container image builder components, project building components, and project dependencies. A large majority of PRs will likely either modify the makefiles or the Package.* files, so I think we can exclude those files from a label category to avoid extra noise.

We should change this to:
area:builder for code related to image building. That would include
- Sources/ContainerBuild//*
- Sources/NativeBuilder//*


"area: client":
- Sources/ContainerClient/**/*

"area: networking":
- Sources/ContainerNetworkService/**/*
- Sources/DNSServer/**/*
- Sources/SocketForwarder/**/*
- config/container-network-vmnet-config.json

"area: services":
- Sources/Services/**/*
- Sources/ContainerAPIService/**/*
- Sources/ContainerImagesService/**/*
- Sources/ContainerSandboxService/**/*

"area: runtime":
- Sources/Helpers/RuntimeLinux/**/*
- config/container-runtime-linux-config.json

"area: plugin":
- Sources/ContainerPlugin/**/*

"area: xpc":
- Sources/ContainerXPC/**/*

"area: logging":
- Sources/ContainerLog/**/*

"area: persistence":
- Sources/ContainerPersistence/**/*

"area: terminal":
- Sources/TerminalProgress/**/*

"area: helpers":
- Sources/Helpers/**/*

# Testing
"testing":
- Tests/**/*
- "**/*Test*.swift"
- "**/*Tests.swift"

# Documentation
"documentation":
- docs/**/*
- "**/*.md"
- scripts/make-docs.sh

# Configuration
"configuration":
- config/**/*
- "**/*.json"
- "**/*.toml"
- signing/**/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need this category


# Scripts and tooling
"tooling":
- scripts/**/*
- licenserc.toml
- Makefile
- Protobuf.Makefile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my comment above, I think we can remove this category entirely.


# GitHub specific
"github":
- .github/**/*

# Dependencies
"dependencies":
- Package.swift
- Package.resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my comment above, I think we can remove this category entirely.


# C/C++ code
"c/c++":
- Sources/CVersion/**/*
- "**/*.c"
- "**/*.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what others think here, but I think this category is possibly too small to be useful. We have very little c code and I don't think anyone would really use this label to find or search for PRs.


# Swift protocol buffers
"protobuf":
- "**/*.proto"
- "**/*.pb.swift"
- "**/*.grpc.swift"
- Protobuf.Makefile

32 changes: 32 additions & 0 deletions .github/workflows/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: "Pull Request Labeler"

on:
pull_request:
types: [opened]

permissions:
contents: read
pull-requests: write

jobs:
label:
name: Label Pull Request
if: github.repository == 'apple/container'
runs-on: ubuntu-latest
outputs:
labels-applied: ${{ steps.labeler.outputs.labels-applied }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Apply labels based on file changes
id: labeler
uses: actions/labeler@v5
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
configuration-path: .github/labeler.yml
sync-labels: true


Loading