Skip to content

Efficient get team by servers v3#12881

Open
spraza wants to merge 4 commits intoapple:release-7.3from
spraza:efficient_getTeamByServers-v3
Open

Efficient get team by servers v3#12881
spraza wants to merge 4 commits intoapple:release-7.3from
spraza:efficient_getTeamByServers-v3

Conversation

@spraza
Copy link
Copy Markdown
Collaborator

@spraza spraza commented Mar 28, 2026 •
edited
Loading

[root@praza-dev-centos7-okteto-84f9ff599d-5gkbg foundationdb]# jsd
Note: Ensemble will complete after 50 failed results.
Note: Ensemble will complete after 500000 runs.
Starting ensemble
Uploading: .=131072: ............................................................................................................................................................................................................................................................................. DONE! Total=35186443
20260328-020749-praza-86f99d1ad7f1d7a9 compressed=True data_size=35186443 fail_fast=50 max_runs=500000 priority=100 sanity=False submitted=20260328-020749 timeout=5400 username=praza

20260328-031310-praza-09f29068f5182a61 compressed=True data_size=35185009 fail_fast=50 max_runs=500000 priority=100 sanity=False submitted=20260328-031310 timeout=5400 username=praza

results:
20260328-031310-praza-09f29068f5182a61 compressed=True data_size=35185009 duration=16374625 ended=500000 fail=8 fail_fast=50 max_runs=500000 pass=499992 priority=100 remaining=0 runtime=2:26:10 sanity=False started=500000 stopped=20260328-053920 submitted=20260328-031310 timeout=5400 username=praza

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@spraza spraza force-pushed the efficient_getTeamByServers-v3 branch from f6b6a61 to f0ebdb8 Compare March 28, 2026 01:24
@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: f6b6a61
  • Duration 0:03:36
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (f6b6a610f43c749d8d4c4540f4708292e4e41ae9) for primary source and source version f6b6a610f43c749d8d4c4540f4708292e4e41ae9
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: f6b6a61
  • Duration 0:04:14
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (f6b6a610f43c749d8d4c4540f4708292e4e41ae9) for primary source and source version f6b6a610f43c749d8d4c4540f4708292e4e41ae9
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: f6b6a61
  • Duration 0:04:17
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (f6b6a610f43c749d8d4c4540f4708292e4e41ae9) for primary source and source version f6b6a610f43c749d8d4c4540f4708292e4e41ae9
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: f6b6a61
  • Duration 0:04:14
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (f6b6a610f43c749d8d4c4540f4708292e4e41ae9) for primary source and source version f6b6a610f43c749d8d4c4540f4708292e4e41ae9
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: f0ebdb8
  • Duration 0:04:08
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: f6b6a61
  • Duration 0:06:42
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (f6b6a610f43c749d8d4c4540f4708292e4e41ae9) for primary source and source version f6b6a610f43c749d8d4c4540f4708292e4e41ae9
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: f6b6a61
  • Duration 0:07:15
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (f6b6a610f43c749d8d4c4540f4708292e4e41ae9) for primary source and source version f6b6a610f43c749d8d4c4540f4708292e4e41ae9
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: f0ebdb8
  • Duration 0:08:04
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: f0ebdb8
  • Duration 0:08:15
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: f0ebdb8
  • Duration 0:08:38
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

gxglass
gxglass reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gxglass gxglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

fdbserver/DDTeamCollection.actor.cpp Outdated
ACTOR static Future<Void> serverGetTeamRequests(DDTeamCollection* self, TeamCollectionInterface tci) {
loop {
GetTeamRequest req = waitNext(tci.getTeam.getFuture());
state GetTeamRequest req = waitNext(tci.getTeam.getFuture());
Copy link
Copy Markdown
Collaborator

@gxglass gxglass Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: this non-state --> state change no longer needed

@spraza spraza force-pushed the efficient_getTeamByServers-v3 branch from f0ebdb8 to bf44223 Compare March 28, 2026 02:52
spraza and others added 4 commits March 27, 2026 19:52
@spraza
Add hash index for getTeamByServers O(1) lookup
c2cca1a
@jzhou77 @spraza
Suppress PingLatency events (apple#12316)
f0db5f1 
pingLatencyLogger iterates all peers and check one peer every 3s. This event
has become very frequent for logging, thus reduced.
@xy-54321 @spraza
Update version range for Snap Restart test (apple#12283)
6475fb7
@jzhou77 @spraza
Fix restarting test failures (apple#12324)
94ea9b0 
7.4.3 was used as old binary and the error is invalid_tuple_data_type.
@spraza spraza force-pushed the efficient_getTeamByServers-v3 branch from bf44223 to 94ea9b0 Compare March 28, 2026 02:52
@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: bf44223
  • Duration 0:03:30
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (bf442233c7947cea61e7773d957e8d343b9e3534) for primary source and source version bf442233c7947cea61e7773d957e8d343b9e3534
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: bf44223
  • Duration 0:04:12
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (bf442233c7947cea61e7773d957e8d343b9e3534) for primary source and source version bf442233c7947cea61e7773d957e8d343b9e3534
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: bf44223
  • Duration 0:04:12
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (bf442233c7947cea61e7773d957e8d343b9e3534) for primary source and source version bf442233c7947cea61e7773d957e8d343b9e3534
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: bf44223
  • Duration 0:04:12
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (bf442233c7947cea61e7773d957e8d343b9e3534) for primary source and source version bf442233c7947cea61e7773d957e8d343b9e3534
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 94ea9b0
  • Duration 0:03:48
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: bf44223
  • Duration 0:06:42
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (bf442233c7947cea61e7773d957e8d343b9e3534) for primary source and source version bf442233c7947cea61e7773d957e8d343b9e3534
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: bf44223
  • Duration 0:07:27
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (bf442233c7947cea61e7773d957e8d343b9e3534) for primary source and source version bf442233c7947cea61e7773d957e8d343b9e3534
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 94ea9b0
  • Duration 0:08:12
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 94ea9b0
  • Duration 0:08:16
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 28, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 94ea9b0
  • Duration 0:08:21
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

alecgrieser
alecgrieser approved these changes Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecgrieser alecgrieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also had a look, and I couldn't find any other location where the teams vector was being updated without the new map being updated

fdbserver/DDTeamCollection.actor.cpp

bool DDTeamCollection::removeTeam(Reference<TCTeamInfo> team) {
TraceEvent("RemovedServerTeam", distributorId).detail("Team", team->getDesc());
teamsByServerIDs.erase(team->getServerIDsStr());
Copy link
Copy Markdown
Contributor

@alecgrieser alecgrieser Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: It may make sense to make this call to erase conditional on actually finding the team. The call to erase if the team isn't found should be a no-op, but it shouldn't hurt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecgrieser alecgrieser alecgrieser approved these changes

@gxglass gxglass gxglass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spraza @foundationdb-ci @alecgrieser @gxglass @jzhou77 @xy-54321