Added support for temporal cloud via api key #29
Conversation
| /// requests to the Temporal server. This provides an alternative to mTLS certificate authentication | ||
| /// for Temporal Cloud deployments. | ||
| /// | ||
| /// If both an API key and mTLS certificates are configured, the API key takes precedence for |
There was a problem hiding this comment.
I’m not sure if “takes precedence” is the right wording here, since both transport security and the API key are configured, I assume Temporal Cloud simply prioritizes authentication via the API key?
| instrumentation: Instrumentation, | ||
| namespace: String = "default", | ||
| identity: String? = nil, | ||
| apiKey: String? = nil, |
There was a problem hiding this comment.
Note that this key can only be set once and cannot be updated anymore after that, in contrast to the C# SDK: https://github.com/temporalio/sdk-dotnet/blob/75baab835682b7ea7bc87b3bc225c8b0526b33da/src/Temporalio/Client/TemporalConnection.cs#L98
There was a problem hiding this comment.
| /// requests to the Temporal server. This provides an alternative to mTLS certificate authentication | ||
| /// for Temporal Cloud deployments. | ||
| /// | ||
| /// If both an API key and mTLS certificates are configured, the API key takes precedence for |
|
Also some tests seem to fail constantly with that change: https://github.com/apple/swift-temporal-sdk/actions/runs/18418846103/job/52488729769?pr=29 |
|
I'm closing this because I don't think I'm going to be able to solve this implementation. I keep running into SegFaults that you can see in #27. As I can tell workers use the Rust core, but direct client calls use a separate Swift implementation. Was trying to resolve that with this fork. but wasn't actually able to get anything to build successfully on linux for a deploy. |
2 participants
Motivation
Added support for API Keys for temporal cloud.