Arduino_H7_Video: stop reallocating rotate buffer on every redraw#1115
Open
spielp wants to merge 1 commit into
Open
Arduino_H7_Video: stop reallocating rotate buffer on every redraw#1115spielp wants to merge 1 commit into
spielp wants to merge 1 commit into
Conversation
When the display is configured for rotation, lvgl_displayFlushing() reallocated rotated_buf to w*h*4 bytes on every flush, i.e. on every screen redraw. Because the dirty-area size varies frame to frame, this churned the heap continuously and could fragment it until the allocation failed mid-draw, crashing under sustained redrawing (e.g. on the Giga Display Shield). The result was also assigned straight back into rotated_buf, leaking the old block and dereferencing NULL on failure. Grow the buffer only when a larger area arrives and converge to the max chunk size.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the display is configured for rotation, lvgl_displayFlushing() reallocated rotated_buf to wh4 bytes on every flush, i.e. on every screen redraw. Because the dirty-area size varies frame to frame, this churned the heap continuously and could fragment it until the allocation failed mid-draw, crashing under sustained redrawing (e.g. on the Giga Display Shield). The result was also assigned straight back into rotated_buf, leaking the old block and dereferencing NULL on failure.
Grow the buffer only when a larger area arrives and converge to the max chunk size.