Skip to content

Arduino_H7_Video: stop reallocating rotate buffer on every redraw #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spielp wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

Arduino_H7_Video: stop reallocating rotate buffer on every redraw #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ void Arduino_H7_Video::set(int x, int y, uint8_t r, uint8_t g, uint8_t b) {
#if __has_include("lvgl.h")
#if (LVGL_VERSION_MAJOR == 9)
static uint8_t* rotated_buf = nullptr;
static size_t rotated_buf_size = 0;
void lvgl_displayFlushing(lv_display_t * disp, const lv_area_t * area, unsigned char * px_map) {
uint32_t w = lv_area_get_width(area);
uint32_t h = lv_area_get_height(area);
Expand All @@ -251,7 +252,22 @@ void lvgl_displayFlushing(lv_display_t * disp, const lv_area_t * area, unsigned
lv_display_rotation_t rotation = lv_display_get_rotation(disp);
lv_area_t rotated_area;
if (rotation != LV_DISPLAY_ROTATION_0) {
rotated_buf = (uint8_t*)realloc(rotated_buf, w * h * 4);
/* Grow the rotate buffer only when a larger area arrives, instead of reallocating on every flush. The per-flush realloc churned the heap
and could fail mid-draw (and leaked / dereferenced NULL because the result was assigned straight back to rotated_buf). */
size_t needed = w * h * 4;
if (needed > rotated_buf_size)
{
uint8_t *p = (uint8_t *)realloc(rotated_buf, needed);
if (p == NULL)
{
LV_ASSERT_MSG(false, "Failed to allocate rotated_buf");
return;
}

rotated_buf = p;
rotated_buf_size = needed;
}

lv_color_format_t cf = lv_display_get_color_format(disp);
#if (LVGL_VERSION_MINOR < 2)
rotation = LV_DISPLAY_ROTATION_90; // bugfix: force 90 degree rotation for lvgl 9.1 end earlier
Expand Down Expand Up @@ -291,4 +307,4 @@ void lvgl_displayFlushing(lv_disp_drv_t * disp, const lv_area_t * area, lv_color
#endif
#endif

/**** END OF FILE ****/
/**** END OF FILE ****/
Loading