refactor: make bzlmod create host repos for toolchains #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
refactor.bzlmod.creates.host.repos
branch
from
1e70b1e to
47b115e
Compare
aignas
approved these changes
May 18, 2025
| name = toolchain_info.name, | ||
| _internal_bzlmod_toolchain_call = True, | ||
| **kwargs | ||
| ) | ||
| loaded_platforms[full_python_version] = toolchain_registered_platforms | ||
| host_compatible = [] |
| @@ -375,6 +375,8 @@ def _host_toolchain_impl(rctx): | |||
| if not rctx.delete(python_tester): | |||
| fail("Failed to delete the python tester") | |||
|
|
|||
| # NOTE: The term "toolchain" is a misnomer for this rule. This doesn't define | |||
| # a repo with toolchains or toolchain implementations. | |||
There was a problem hiding this comment.
What if we rename it to host_compatible_python_repo?
aignas
reviewed
May 18, 2025
| # Repo rules can't accept dict[str, bool], so encode them as a string value. | ||
| toolchain_set_python_version_constraints[key] = ( | ||
| "True" if entry.set_python_version_constraint else "False" | ||
| ) |
There was a problem hiding this comment.
Below here, the host_compatible toolchain list should be passed to the pythons_hub so that we keep the right contents in the interpreters.bzl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the creation of the host_toolchain repos into the bzlmod phase.
This is to facilitate future work to allow for when a a particular version
doesn't provide a host-compatible variant
DO NOT MERGE:
Work towards #2081