-
Notifications
You must be signed in to change notification settings - Fork 389
ci: add ubuntu-24.04-arm runner to workflows #1922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add ubuntu-24.04-arm runner to workflows #1922
Conversation
Hey, @notmandatory can you please review this PR? Thank you! |
Hey @vkprogrammer-001, is this a WIP PR ? I noticed that all the commits are currently unsigned and share the same name and description. Could you please rebase and sign the commits? Also, I recommend adopting the conventional commit format for better clarity and consistency, everything I said here you can find in the contributing guide, it's worth taking a look. Other than that, everything looks good to me, cargo fmt, Clippy and all tests passed successfully. Great work! |
This adds ARM64 architecture support to the CI matrix for testing on ARM-based infrastructure like AWS Graviton servers.
0c11533
to
df4b547
Compare
Thank you for catching that! I’ve addressed the issue with the unsigned commits—rebased everything and ensured the commit is now correctly signed and follows the conventional format outlined in the contributing guide. The PR should now be all set. Appreciate the reminder about the project guidelines! |
ACK. i run cargo clippy, fmt and test all have passed, good job! |
Link to the PR in BDk wallet: bitcoindevkit/bdk_wallet#200 |
Changes
ubuntu-24.04-arm
runner to CI matrix for ARM64 architecture supportbdk_electrum
bdk_bitcoind_rpc
bdk_testenv
bdk_esplora
Rationale
This change enables CI testing on ARM64 architecture (e.g., AWS Graviton servers) while handling the architecture mismatch with the electrs binary. The electrs binary is currently only available for x86_64, causing "Exec format error (os error 8)" when attempting to run on ARM.
Future Improvements
While this solution enables CI to pass on ARM, it's a temporary workaround. Long-term improvements could include:
Testing
Issue: bitcoindevkit/bdk_wallet#23