-
Notifications
You must be signed in to change notification settings - Fork 20
ci: Add Ubuntu 24.04 ARM support for build-test job #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: Add Ubuntu 24.04 ARM support for build-test job #200
Conversation
Hey, @notmandatory can you please review this PR? Thank you! |
Did you see the PR and discussion here: bitcoindevkit/bdk#1905 You may run into the same issue and help review that PR if you have any suggestions. |
Pull Request Test Coverage Report for Build 14604822386Details
💛 - Coveralls |
Looks like this one also needs to be rebased on the master branch. |
I reviewed PR bitcoindevkit/bdk#1905 and found an issue with electrsd. In my PR #1922, I resolved this by excluding electrs-dependent tests on ARM runners instead of building ARM versions of electrs and bitcoind. I specifically updated the workflow to:
This approach allowed the ARM CI to pass without altering the electrsd crate itself. It's a temporary solution to maintain progress while we work on a comprehensive fix for ARM-compatible electrsd. Since we have separated bdk_wallet from bdk, no additional adjustments are needed in the bdk_wallet. |
Hello @notmandatory, I've verified that this PR is already rebased on the latest master branch. Both branches point to the same commit (3e61d2a). Is there something specific in the CI that needs attention? Happy to address any other issues. |
Ah ok I see the issue, I'll need to rename the required checks to use "ubuntu-latest". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 63e7f4c
Description
This PR adds Ubuntu 24.04 ARM as a target platform for the build-test job in our CI workflow. This change will help ensure our codebase works correctly on ARM architecture.
Changes
ubuntu-24.04-arm
to the matrix of operating systems in the build-test jobruns-on
to use the matrix variable for OS selectionTesting
The CI workflow will now run in parallel on both:
Each platform will test all combinations of:
Benefits
Issue: #23